Fix issues around extends with relative paths
#1296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theSuess
force-pushed
the
fix/extends-relative-paths
branch
from
c096bc2 to
86530df
Compare
All code paths up to here already join the context path and with the check above we're sure the file exists so joining again leads to paths that don't exist Signed-off-by: Dominik Süß <[email protected]>
This fixes relative paths when using `extends` to include another service from a different directory Signed-off-by: Dominik Süß <[email protected]>
theSuess
force-pushed
the
fix/extends-relative-paths
branch
from
86530df to
72d4554
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some issues around using
extendswith relative paths:This ensures the same behavior as docker-compose: https://docs.docker.com/compose/how-tos/multiple-compose-files/extends/#relative-paths