feat: replace ColoringBookSection with LiteratureCarousel (Issue #114) - #527
feat: replace ColoringBookSection with LiteratureCarousel (Issue #114)#527Prat260104 wants to merge 1 commit into
Conversation
2c57958 to
2b7fa54
Compare
|
Hi @ashley-cui @TomSweeneyRedHat , 
Tried to keep it consistent with the existing website layout , |
e46788a to
3cf9792
Compare
|
@Prat260104 looks like a rebase may be needed, or some other conflict resolution. |
Yes sir Just one of PR got merged so i need to rebase and resolve the conflicts . |
1d93805 to
ecb209e
Compare
Hi @TomSweeneyRedHat sir, I have resolved the merge conflicts and also squashed the commits. Thank you for reviewing the PR. |
Hi @TomSweeneyRedHat sir, |
The coloring book section only displayed the Container Commandos coloring book, which is too limited. The project now has multiple literature resources (like the "Podman in Action" and "Podman for DevOps" books) that should be highlighted for users to learn more about Podman. Introduce the LiteratureCarousel component to showcase all three books on both the home and features pages. The carousel allows users to easily navigate between the different publications and view information about them. - Created LiteratureCarousel component using existing carousel patterns - Configured books: Container Commandos, Podman in Action, and Podman for DevOps - Replaced ColoringBookSection with LiteratureCarousel on home and features pages - Added randomized initial slide selection to ensure equal visibility for all books - Cleaned up obsolete ColoringBookSection component and its data Fixes: containers#114 Signed-off-by: Prateek Rai <prateekrai903@gmail.com>
ecb209e to
312e1f0
Compare
|
Now all books are consistent in sizing 
|
|
Hi @ashley-cui mam, The main issue was that the "Container Commandos" book has extra images (coloring pages) displayed below the main content, while the other two books don't. This caused inconsistent carousel heights when navigating between items. made some changes to fix this also and ensure consistency Ready to make any further changes based on your feedback Thanks ! |
|
The coloring book seems to be just a bit off from the other two still, but it's very slight and I don't think it's a problem. I'll give this an LGTM, and will let @ashley-cui decide if it's mergeable. |
Thanks for the review! I'm happy to make any changes based on the feedback. I tried to keep the design as consistent as possible with the other books, but if there are any adjustments you'd like, I'm ready to update them. |
3 participants
Description
Fixes #114
Added Podman in Action and Podman for DevOps to the books/resources section.
Since we now have multiple books, I replaced the existing
ColoringBookSectionwith aLiteratureCarouselso users can go through all three books.Changes
Added
static/data/literature.tsfor the three books:Added a new
LiteratureCarouselcomponent while keeping the existing look and layout.Added left/right navigation and dots for switching between books.
The first book shown is picked randomly on page load, as mentioned in the issue.
Removed the old
ColoringBookSectionand moved its content to the new carousel.Updated the home and features pages to use
LiteratureCarousel.Added links and cover images for the two new books. Since Podman for DevOps is a paid book, its button says Learn More instead of Download.
For Book data
Podman in Action — Official free Red Hat Developer e-book. The description and cover image are sourced from developers.redhat.com.
Podman for DevOps — This is a paid Packt Publishing book rather than a free Red Hat e-book