Skip to content

fix(a11y): add alt text to images missing it #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Aditya-132 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): add alt text to images missing it #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/ui/ArticleCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ function ArticleCard(props: ArticleCardProps) {
</div>
<img
src={props.imgSrc}
alt={props.title}
className=" col-start-1 row-start-1 h-full w-full rounded-sm object-cover lg:w-80"
/>
</div>
Expand Down Expand Up @@ -78,7 +79,7 @@ function ArticleCard(props: ArticleCardProps) {
</h3>
{parse(abbrSubtitle)}
<PublishDate date={props.date} styles="row-start-1 col-start-1 z-10 my-2" />
<img src={props.imgSrc} className="object-fit col-start-1 row-start-1 rounded-sm" />
<img src={props.imgSrc} alt={props.title} className="object-fit col-start-1 row-start-1 rounded-sm" />
<p className="text-purple-700">
By: <a href={props.author_link}>{props.display_name}</a>
</p>
Expand Down
4 changes: 2 additions & 2 deletions src/pages/features.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const PodmanDesktopSection = () => {
</div>
<div className="container flex flex-col md:flex-row items-center">
<div id="imgdiv" className="mx-auto w-full md:w-auto">
<img id="pdlogo" className="mx-auto" src="logos/optimized/podman-desktop-logo-200w-198h.webp" />
<img id="pdlogo" className="mx-auto" src="logos/optimized/podman-desktop-logo-200w-198h.webp" alt="Podman Desktop logo" />
</div>
<div className="md:w-1/2 xl:w-3/4">
<p className="my-8 align-middle text-2xl leading-relaxed">
Expand Down Expand Up @@ -158,7 +158,7 @@ const PodmanCLISection = () => {
</div>
<div className="container mb-4 grid gap-2 lg:grid-cols-3">
<div className="mx-auto">
<img className="max-h-[200px]" src="images/optimized/podman-selkie-385w-358h.webp" />
<img className="max-h-[200px]" src="images/optimized/podman-selkie-385w-358h.webp" alt="Podman Selkie mascot" />
</div>
<div className="col-span-2">
<p className="my-8 align-middle text-2xl leading-relaxed">
Expand Down