fix: add key prop to mapped meeting dropdown options - #578
Open
Aditya-132 wants to merge 1 commit into
Open
Conversation
getDropdownOption rendered DropDownOption elements from .map() without a key, producing React's missing-key warning and forcing index-based reconciliation for the meeting dropdown list. Add a key to each element. Signed-off-by: Aditya-132 <adityachincholkar11@gmail.com>
Aditya-132
force-pushed
the
fix/dropdown-missing-key
branch
from
July 29, 2026 07:37
ccf2bc4 to
7ade60a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
getDropdownOptioninCommunityMeetingsCardGridrendered a list ofDropDownOptionelements from.map()without akey, which triggers React's "Each child in a list should have a unique key prop" warning and makes reconciliation fall back to index matching. Adds akeyto each mapped element.Fixes #575
Testing
yarn buildsucceeds and generatesbuild/index.html(matching CI).