Skip to content

fix(web): resolve DOM nesting warnings and broken doc links #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prakharsingh-74 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(web): resolve DOM nesting warnings and broken doc links #625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ The documentation for Podman is located
## Installing Podman

For installing or building Podman, please see the
[installation instructions](docs/installation).
[installation instructions](./installation).

## Familiarizing yourself with Podman

Expand Down Expand Up @@ -202,7 +202,7 @@ Checkpointing a container stops the container while writing the state of all
processes in the container to disk. With this, a container can later be
migrated and restored, running at exactly the same point in time as the
checkpoint. For more details, see the
[checkpoint instructions](docs/checkpoint).
[checkpoint instructions](./checkpoint).

## Integration Tests

Expand Down
8 changes: 4 additions & 4 deletions src/components/ui/CustomCard/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ type SubcardButtonProps = {

type CardInfoButtonProps = {
data: SubcardButtonProps[];
primary: Boolean;
method: Function;
primary: boolean;
method?: (button: SubcardButtonProps) => void;
};

function CardHeader(props) {
Expand All @@ -30,9 +30,9 @@ function CardBody(props) {
const { text } = props;
return (
<div className="mx-2 my-6 overflow-y-auto lg:my-8">
<p id="cardBody-parsed" className="text-gray-700 dark:text-gray-100">
<div id="cardBody-parsed" className="text-gray-700 dark:text-gray-100">
<Markdown text={text} />
</p>
</div>
</div>
);
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/community.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ const DropdownContent = (props): JSX.Element => {
<ul>
{props.map((link, index) => {
return (
<li className="my-2 rounded-md px-2 transition duration-150 ease-linear hover:bg-purple-700 hover:text-white">
<li key={index} className="my-2 rounded-md px-2 transition duration-150 ease-linear hover:bg-purple-700 hover:text-white">
<a href={link.path} className=" w-full hover:text-white hover:no-underline">
{link.text}
</a>
Expand Down
4 changes: 2 additions & 2 deletions src/theme/NotFound.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export default function NotFound(): JSX.Element {
{Messages[rand_seed]}
</div>
</h1>
<p>
<div>
<div
id="theme-NotFound-p1">
We could not find what you were looking for: &nbsp;
Expand All @@ -83,7 +83,7 @@ export default function NotFound(): JSX.Element {
path={searchLink} />
</span>
</div>
</p>
</div>
</div>
</div>
</main>
Expand Down