fix(ui): resolve blue box overlap on CodeExampleSection - #629
Open
JituRewar wants to merge 2 commits into
Open
Conversation
Fixes: containers#628 Signed-off-by: Jitendra Rewar <jiturewar9@gmail.com>
Author
|
Now i successfully restore previous design of blue boxes and make functional to scrollbar by keeping blue boxes at their same position as @MuhammadAashirAslam suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #628
Concisely describe the change
The blue info boxes on the homepage were overlapping the terminal
code block text, making it hard to read. This happened because
both the code block and the blue boxes were placed in overlapping
CSS Grid columns (code block: cols 1–11, blue boxes: cols 9–12),
and a -z-50 z-index hack was used to hide this overlap.
Fixed by giving each element its own dedicated columns:
No more overlap, no more z-index hacks.
Before-

After-

Checklist
Fixes: #628in commit message