Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop minikube CI test #23237

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Jul 9, 2024

This test flakes frequently and its status is completely ignored in CI. At the time of this commit, nobody has stepped up to debug or fix it. Drop the test.

(I'm open to just dropping it from the YAML and leaving all the other bits intact in case someone wants to re-enable it later)

Also ref: #23235

Fixes: #21931

Does this PR introduce a user-facing change?

None

This test flakes frequently and its status is completely ignored in CI.
At the time of this commit, nobody has stepped up to debug or fix it.
Drop the test.

Signed-off-by: Chris Evich <[email protected]>
@cevich cevich added the No New Tests Allow PR to proceed without adding regression tests label Jul 9, 2024
@cevich cevich mentioned this pull request Jul 9, 2024
@mheon
Copy link
Member

mheon commented Jul 9, 2024

No objections, LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 10, 2024
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich, giuseppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 58aa1cf into containers:main Jul 10, 2024
89 checks passed
@stale-locking-app stale-locking-app bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Oct 9, 2024
@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

minikube flakes
3 participants