-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update module github.com/crc-org/crc/v2 to v2.42.0 #23289
base: main
Are you sure you want to change the base?
Conversation
ℹ Artifact update noticeFile name: go.modIn order to perform the update(s) described in the table above, Renovate ran the
Details:
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: renovate[bot] The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
A friendly reminder that this PR had no activity for 30 days. |
8000f10
to
9c449e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
9c449e5
to
66c7b4d
Compare
New changes are detected. LGTM label has been removed. |
@Luap99 FYI As expected, Renovate is now unhappy with the hard-coded 1.21 in https://github.com/containers/automation/blob/4739c8921cc52a1c046c2d5248d88e6f8b8755de/renovate/defaults.json5#L126 . Do we manually update every project before switching that? |
If we update the version there then renovate starts proposing go 1.22 upgrades to projects on 1.21 with a toolchain version we do not want right? And these likely pass CI and someone might merge them because of that without knowing that we dislike toolchain. But then without it all the projects on 1.22 are broken so I guess we should just switch it there I do wonder though if we can set the |
Do you mean that we want Go 1.22 on Podman but not on some of the other projects? (If so, we probably need to move the constraint from the shared file.) Or that we do want Go 1.22 everywhere, but if we let Renovate do it, it will use a high version in the
That’s almost certainly possible; this file is included in the various projects’ |
(BTW I now see projects requiring specific X.Y.Z. versions of |
this
Right that is needed for the most projects anyway to fix CI configs to not run on f39 on cirrus and packit which makes this a PITA Here are the other updates I did, I am not planning to work on the other repos migration bu happy to review |
Right but until this is done the renovate PRs in the projects with go 1.22 will fail, so depending on how long the process takes this may not be wanted. |
For the record, the other updates: I mostly tend to prefer having these settings shared and managed centrally; I think we can get the updates done in a small number of days — it’s very easy to ignore Renovate PRs for a few days, but creating those PRs to move the configuration is immediate work and an ongoing commitment. |
Do you know if this is intentionally on their end? This will suck big time.... What is even the point of forcing all consumers on a specific minor version? Just to ensure they build with specific go std bug fixes?? This will make tracking the versions really a pain, it is not just like were are dealing with fedora/debian upstream. Centos stream, epel/RHEL builds and so on. Other packagers that try to build podman, etc... we really cannot move the version requirements to fast.
Yes fair enough, as long as it takes a few days only I can live with the shared config. |
In this case it’s things like sigstore/sigstore#1786 .
The design intends to allow that, yes — and that notably includes security fixes. 1.22.5 does advertise security fixes.
It seems to me that the primary restriction is on the 1.Y streams; within these streams, at least Fedora tends to update to 1.Y.X updates for security fixes rather than backport. I don’t know what Debian does. |
66c7b4d
to
c59c1fb
Compare
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
c59c1fb
to
292e233
Compare
This PR contains the following updates:
v2.38.0
->v2.42.0
Release Notes
crc-org/crc (github.com/crc-org/crc/v2)
v2.42.0
Compare Source
v2.41.0
: 2.41.0-4.16.7Compare Source
Downloads are available at: https://developers.redhat.com/content-gateway/rest/mirror/pub/openshift-v4/clients/crc/2.41.0
To use these binaries follow the instructions at https://console.redhat.com/openshift/create/local to obtain the needed pull-secret.
Notable Changes
crc status
for the MicroShift preset #4265ed25519
keys for SSH to the crc instances #4304git shortlog
e6495fe
cut v2.41.070535de
build(deps): bump github.com/containers/gvisor-tap-vsock80dcac9
test: fix ssh key path in podman testse222fc9
Update Openshift/microshift version to 4.16.7 (stable channel)8bcc1b9
Revert "build(deps): bump github.com/golangci/golangci-lint in /tools"ee36371
Rename GetRsaPrivateKeyPath to GetECDSAPrivateKeyPath for backward compatibility7bb32ee
ssh: Useed25519
algorithm instead ECDSA831c5f9
build(deps): bump github.com/golangci/golangci-lint in /tools7b042f7
build(deps): bump golang.org/x/tools from 0.23.0 to 0.24.0 in /tools8a88ac7
Fix: go-lint fixes for go tools 0.24.0 updateab63fcd
macos: Remove no longer needed code896d7f4
macos: Boot the VM using UEFI5c2c473
build(deps): bump github.com/containers/image/v5 from 5.32.0 to 5.32.1a732394
build(deps): bump github.com/onsi/ginkgo/v2 from 2.19.1 to 2.20.0540c261
build(deps): bump golang.org/x/sys from 0.23.0 to 0.24.03e3c88c
build(deps): bump libvirt.org/go/libvirtxml from 1.10005.0 to 1.10006.04ab724b
build(deps): bump github.com/spf13/cast from 1.6.0 to 1.7.00f161e3
build(deps): bump golang.org/x/net from 0.27.0 to 0.28.09ebd0ec
build(deps): bump golang.org/x/crypto from 0.25.0 to 0.26.0e28d25f
Display PersistentVolumeUsage incrc status
7c63a82
build(deps): bump golang.org/x/sys from 0.22.0 to 0.23.0v2.40.0
: 2.40.0-4.16.4Compare Source
Downloads are available at: https://developers.redhat.com/content-gateway/rest/mirror/pub/openshift-v4/clients/crc/2.40.0
To use these binaries follow the instructions at https://console.redhat.com/openshift/create/local to obtain the needed pull-secret.
Notable Changes
git shortlog
a14925b
cut v2.40.0759713f
Doc: update macOS supported version requirement75851ab
update openshift and microshift bundles to 4.16.4095b397
build(deps): bump github.com/onsi/gomega from 1.34.0 to 1.34.18c3504a
build: Use $@ in macos-amd64 target3ed82fc
build: Add go.mod/go.sum and Makefile toSOURCES
16cf22d
build: Ensure binaries are rebuilt on any source change0b5de9b
build(deps): bump github.com/containers/image/v5 from 5.31.1 to 5.32.0c24c448
update-go: Update script to get go major and minor versionef819b2
Update libvirt driver to 0.13.96af4fb9
Add WaitForKubeAPIServerCertRenewal helperb88f1e1
cluster: Update the location of aggregator-client certificatebeca62f
start: Remove workaround to delete apiserver pod in case of aggregator-client-ca regeneratede3d5e47
build(deps): bump github.com/onsi/ginkgo/v2 from 2.19.0 to 2.19.1db4810b
build(deps): bump github.com/containers/gvisor-tap-vsockec24d65
Issue #4279 Fix case sensitive WSL2 validation check71b8eb6
new action that push qe images for new tag2fa7958
build(deps): bump github.com/ProtonMail/go-crypto56367f1
build(deps): bump github.com/ProtonMail/go-cryptod93b545
clusteroperator: Ignore EvaluationConditionsDetected condition54882f6
Show MicroShift version as part of 'version' command1a915c7
build: replace amd64 with GOARCH in make target 'release'v2.39.0
: 2.39.0-4.16.0Compare Source
Downloads are available at: https://developers.redhat.com/content-gateway/rest/mirror/pub/openshift-v4/clients/crc/2.39.0
To use these binaries follow the instructions at https://console.redhat.com/openshift/create/local to obtain the needed pull-secret.
Notable Changes
git shortlog
0849cb8
cut v2.39.0a0fa656
e2e: update config feature to work with new libvirt driver nameaa46dad
libvirt: Fix machine driver command namec66f5d3
build(deps): bump libvirt.org/go/libvirtxml from 1.10003.0 to 1.10005.05ff9c5e
windows: set text encodig for powershell to utf-8d40cdbd
build(deps): bump golang.org/x/tools from 0.22.0 to 0.23.0 in /toolse6046ed
build(deps): bump golang.org/x/net from 0.26.0 to 0.27.016568b1
build(deps): bump golang.org/x/crypto from 0.24.0 to 0.25.06f668ef
build(deps): bump golang.org/x/term from 0.21.0 to 0.22.0142a009
build(deps): bump golang.org/x/sys from 0.21.0 to 0.22.0d3534af
Update openshift/microshift version to 4.16.0 (stable channel)b3cf378
build: Update k8s and openshift go modules to sync with openshift-4.160dee66e
[qe]e2e: wait longer for monitoring operator to avoid failures, pulling images delay may due to networking22a112d
[QE] fix not catch error for oc loginhttps://github.com/crc-org/crc/issues/4101177c0f1f
Spec: Append arch info for admin-helper and libvirt driver926c78e
libvirt/constants.go: Add arch info to download machine-driver-libvirt binary589e152
constants/constants.go: Add arch info to admin-helper linux binary66f9143
packaging: Don't build rpm for ppc64le arch9c3edd3
Makefile: Use GOARCH for linux-release target5b4318e
Add support to generate aarch64 bits for Linux9a55385
build(deps): bump github.com/ProtonMail/go-crypto41beb85
build(deps): bump github.com/containers/image/v5 from 5.31.0 to 5.31.1Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Never, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.