Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logformatter: tweaks to pass html tidy #23360

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

edsantiago
Copy link
Member

Plus, I think my ampersand-quot change earlier this month
caused problems for firefox. We no longer need it (pull-option
does not need the funky double-quoted curly-brace string),
so, remove it.

Signed-off-by: Ed Santiago [email protected]

None

Plus, I think my ampersand-quot change earlier this month
caused problems for firefox. We no longer need it (pull-option
does not need the funky double-quoted curly-brace string),
so, remove it.

Signed-off-by: Ed Santiago <[email protected]>
@openshift-ci openshift-ci bot added release-note-none approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 22, 2024
Copy link

We were not able to find or create Copr project packit/containers-podman-23360 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@mheon
Copy link
Member

mheon commented Jul 22, 2024

LGTM

@edsantiago
Copy link
Member Author

Yeah, much better

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2024
Copy link
Contributor

openshift-ci bot commented Jul 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Member Author

Windows tests are failing despite retry. Looks like the start hang. Is anyone working on fixing that?

@Luap99
Copy link
Member

Luap99 commented Jul 22, 2024

Windows tests are failing despite retry. Looks like the start hang. Is anyone working on fixing that?

No, it will pass eventually I think. It is just super flaky for some reason, not sure what changed.

I assume this is tracked in you machine flake issue? Properly need to get this assigned to someone.

@edsantiago
Copy link
Member Author

I'm not tracking it, because there are WAY Too many podman-machine flakes, with slightly different symptoms, and it would take me hours to look at each one every day and assign it to "sleep hang" or "something else". So, no, I'm just ignoring them all in my flake catalog.

@Luap99
Copy link
Member

Luap99 commented Jul 22, 2024

#22551?

@edsantiago
Copy link
Member Author

Yes, I've updated #22551 with the last week-or-so of podman machine flakes.

@openshift-merge-bot openshift-merge-bot bot merged commit e317863 into containers:main Jul 22, 2024
78 of 89 checks passed
@edsantiago edsantiago deleted the logformatter-tweaks branch July 22, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants