libpod: cleanupNetwork() return error

[Luap99]

Return the error not just log as the caller can then decide to log this and exit > 0. I also removed the c.valid check as I do not see what the purpose of this would be. c.valid is only false when the ctr was removed but then we should never get there as Cleanup() will not work on a container in removing state.

Does this PR introduce a user-facing change?

None

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

@mheon PTAL

[mheon]

LGTM

[Luap99]

@edsantiago please pick this into the no flake try PRs, I have not seen the flake in #23487 for 3 pushes now but I am not sure if this is just luck because I don't think this is actually changing anything other than the error message.

[edsantiago]

https://api.cirrus-ci.com/v1/artifact/task/4937874783600640/html/int-podman-rawhide-rootless-host-sqlite.log.html#t--Podman-kube-play-test-env-value-from-configmap-and-replace-should-reuse-the-configmap-volume--1

[edsantiago]

Also this hang in debian is a new one I don't recall having seen before, don't know if it's related to any recent work

[Luap99]

Ack I saw a hang on my PR as well but I cannot see how this change would cause this.

[edsantiago]

that's #22246, the one Matt is working on

[Luap99]

that's #22246, the one Matt is working on

Right but #22246 hangs on pod rm --all not on stop --all which you linked which is the bit that concerns me here.

[rhatdan]

safe or save?

[edsantiago]

Is this what you were hoping for?

$ podman [options] stop --all -t 0
Error: removing container 953ccd87aeda89841fa7a2e00020d84c78d74a07d67b6983cce00c6e7572ade5 network: unmounting network namespace for container 953ccd87aeda89841fa7a2e00020d84c78d74a07d67b6983cce00c6e7572ade5: failed to remove ns path: remove /run/user/3445/netns/netns-c979509f-2f3d-b0f5-3e2b-3421610b3fe1: device or resource busy

[edsantiago]

Or this one but I don't see the new error message here either

[Luap99]

Is this what you were hoping for?

$ podman [options] stop --all -t 0
Error: removing container 953ccd87aeda89841fa7a2e00020d84c78d74a07d67b6983cce00c6e7572ade5 network: unmounting network namespace for container 953ccd87aeda89841fa7a2e00020d84c78d74a07d67b6983cce00c6e7572ade5: failed to remove ns path: remove /run/user/3445/netns/netns-c979509f-2f3d-b0f5-3e2b-3421610b3fe1: device or resource busy

yes that one should be fixed with the fixes in c/common I think containers/common#2112 #23519

But that doesn't fix the very clear issue of podman calling cleanup twice.

[rhatdan]

/lgtm