podman-manifest-remove: update docs and help output #23983
Conversation
nalind
added
the
No New Tests
cmd/podman/manifest/remove.go
Outdated
| Long: "Removes an image from a manifest list or image index.", | ||
| Use: "remove LIST DIGEST", | ||
| Short: "Remove an item from a manifest list or image index", | ||
| Long: "Removes an item from a manifest list or image index.", | ||
| RunE: remove, | ||
| Args: cobra.ExactArgs(2), | ||
| ValidArgsFunction: common.AutocompleteImages, |
There was a problem hiding this comment.
If a image is not correct then please change the shell completion for images here, I guess we still want the first arg the images to be completed? (is there a way to only list manifest lists for the first arg and no all images? and then if possible provide the autocompletion for the digest as second arg?)
There was a problem hiding this comment.
Okay, took a run at that.
nalind
force-pushed
the
manifest-remove-docs
branch
2 times, most recently
from
24bfe5e
to
1c91823
Compare
* podman manifest remove doesn't accept references as descriptions of what to remove from a list or index; only use digests in the man page * podman manifest remove only removes one thing at a time; correct the man page examples Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
manifest-remove-docs
branch
from
1c91823
to
00c13af
Compare
openshift-ci
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
podman manifest removedoesn't accept references as descriptions of what to remove from a list or index; only use digests in the man pagepodman manifest removeonly removes one thing at a time; correct the man page examplesDoes this PR introduce a user-facing change?