CI: Quadlet rootfs test: use container image as rootfs #24019
Conversation
Test was written to use / (root). This is not parallel-safe. Fixes: containers#23909 Signed-off-by: Ed Santiago <[email protected]>
openshift-ci
bot
added
release-note-none
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, ygalblum The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| skip_if_no_selinux | ||
| skip_if_rootless |
There was a problem hiding this comment.
I am somewhat sure these can be removed now?
There was a problem hiding this comment.
Wouldn't the mounts need complicated unshare? Would those work inside quadlet?
There was a problem hiding this comment.
ah right yes you would need to use unshare rootless but yes as they all share the same userns the mounts should work with quadlet. Anyway I guess it is not really important to test it rootless. (although I do not get the no_selinux skip either)
I guess I just merge it as it is the same as before
/lgtm
Test was written to use / (root). This is not parallel-safe.
Fixes: #23909
Signed-off-by: Ed Santiago [email protected]