Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove usage of deprecated --storage in the doc of podman-build #24021

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ruihe774
Copy link
Contributor

None

in the doc of podman-build

Signed-off-by: Misaki Kasumi <[email protected]>
Copy link

We were not able to find or create Copr project packit/containers-podman-24021 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel: https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

1 similar comment
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove external containers with podman rm --force see the docs there. So the last sentence should stay otherwise users do not know how to remove them

@lsm5
Copy link
Member

lsm5 commented Sep 20, 2024

/packit build

@baude
Copy link
Member

baude commented Sep 20, 2024

agree with @Luap99 ... if you repush, we should be good. Thanks!

@ruihe774
Copy link
Contributor Author

You can remove external containers with podman rm --force see the docs there. So the last sentence should stay otherwise users do not know how to remove them

I think #7891 has already allowed users to remove external containers directly. No need for --force.

@Luap99
Copy link
Member

Luap99 commented Sep 20, 2024

You can remove external containers with podman rm --force see the docs there. So the last sentence should stay otherwise users do not know how to remove them

I think #7891 has already allowed users to remove external containers directly. No need for --force.

If they are not mounted it seems to work without so yes.

@mheon
Copy link
Member

mheon commented Sep 20, 2024

LGTM on my end

@rhatdan
Copy link
Member

rhatdan commented Sep 20, 2024

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2024
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, ruihe774

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 186a2b8 into containers:main Sep 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants