Add multi-file support to `podman kube play/down` #27292

Honny1 · 2025-10-14T17:29:05Z

This PR enables podman kube play and podman kube down to accept multiple YAML files and URLs in a single command.

Fixes: #26274
Fixes: https://issues.redhat.com/browse/RUN-3586

Does this PR introduce a user-facing change?

podman kube play|down support multiple file as arguments

Honny1 · 2025-10-14T17:36:24Z

cc @axel7083

Honny1 · 2025-10-14T18:43:14Z

The CI is failing due to an unrelated test: Podman search with wildcards.

TomSweeneyRedHat · 2025-10-15T14:54:39Z

cmd/podman/kube/play.go

+		}
+		return response.Body, nil
+	default:
+		return os.Open(fileName)


It just struck me that we're using http.Get() and I don't think we've set it to use TLS? Should we? Also, can this Get ever hang and never timeout?

It should automatically use TLS. I'm not sure about the request timeout, though. I just reused the same function as before, which we're already using in multiple places. Is this considered bad practice in Go?

TomSweeneyRedHat · 2025-10-15T14:56:27Z

A couple of questions for consideration.
Otherwise, LGTM

flouthoc · 2025-10-17T15:54:19Z

cmd/podman/kube/play.go

-		reader = f
+
+		if i < len(args)-1 {
+			combined.WriteString("\n---\n")


Please add a comment on top that this is file seperator ? Maybe also have \n---\n in a const string

I have added a comment and moved it into a const string.

flouthoc

Just one comment, PR looks good overall

packit-as-a-service · 2025-10-20T13:08:03Z

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

Honny1 · 2025-10-21T07:54:03Z

/packit retest-failed

mheon · 2025-10-21T19:58:26Z

cmd/podman/kube/play.go

+	return bytes.NewReader(combined.Bytes()), nil
+}
+
+func readerFromArg(fileName string) (io.ReadCloser, error) {


fileName is confusing here, it can do files or URLs

mheon · 2025-10-21T20:01:45Z

What happens if the user gives us a bunch of files, but one of them isn't valid YAML. Do we fail with a parse error?

mheon · 2025-10-21T20:01:52Z

/approve

Honny1 · 2025-10-22T10:10:39Z

What happens if the user gives us a bunch of files, but one of them isn't valid YAML. Do we fail with a parse error?

Yes, we fail with parse error.

Signed-off-by: axel7083 <[email protected]> fix: update kube play command cobra use Signed-off-by: axel7083 <[email protected]> Add multi-file support to podman kube play/down - Support multiple YAML files and URLs in single command - Combine files with YAML document separators (---) - Refactor for better testability with dependency injection - Update documentation with examples for multiple inputs - Improve memory efficiency with streaming I/O operations Fixes: containers#26274 Fixes: https://issues.redhat.com/browse/RUN-3586 Signed-off-by: Jan Rodák <[email protected]>

Luap99

/lgtm

Luap99 · 2025-10-22T11:21:28Z

cmd/podman/kube/play_test.go

+var configMapYAML = strings.Join([]string{
+	"apiVersion: v1",
+	"kind: ConfigMap",
+	"metadata:",
+	"  name: my-config",
+	"data:",
+	"  key: value",
+}, "\n")
+
+var podYAML = strings.Join([]string{
+	"apiVersion: v1",
+	"kind: Pod",
+	"metadata:",
+	"  name: my-pod",
+}, "\n")
+
+var serviceYAML = strings.Join([]string{
+	"apiVersion: v1",
+	"kind: Service",
+	"metadata:",
+	"  name: my-service",
+}, "\n")
+
+var secretYAML = strings.Join([]string{
+	"apiVersion: v1",
+	"kind: Secret",
+	"metadata:",
+	"  name: my-secret",
+}, "\n")
+
+var namespaceYAML = strings.Join([]string{
+	"apiVersion: v1",
+	"kind: Namespace",
+	"metadata:",
+	"  name: my-namespace",
+}, "\n")


nit: this is quite ugly, go supports multi line strings just fine with the backtick escapes which would make this more readable, but not worth to push again just for this

Luap99 · 2025-10-22T11:24:12Z

cmd/podman/kube/play_test.go

+			want := strings.TrimSpace(tt.expected)
+
+			if got != want {
+				t.Errorf("unexpected output:\n--- got ---\n%s\n--- want ---\n%s", got, want)


another nit: we already depend on assert so might as well use the nicer test hallper such as assert.Equal(), etc...

openshift-ci · 2025-10-22T11:24:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Honny1, Luap99, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [Luap99,mheon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Honny1 · 2025-10-22T11:39:58Z

@Luap99 Should I fix nits?

Luap99 · 2025-10-22T11:42:53Z

@Luap99 Should I fix nits?

No its fine like this

openshift-ci bot added release-note do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Oct 14, 2025

Honny1 force-pushed the pr-multi-file-support-kube branch from 80a686e to 45988c5 Compare October 14, 2025 17:36

Honny1 mentioned this pull request Oct 14, 2025

feat(cmd): podman kube play support multiple arguments #26280

Closed

Honny1 marked this pull request as ready for review October 14, 2025 18:43

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 14, 2025

TomSweeneyRedHat reviewed Oct 15, 2025

View reviewed changes

flouthoc reviewed Oct 17, 2025

View reviewed changes

Honny1 force-pushed the pr-multi-file-support-kube branch from 45988c5 to 6e57e92 Compare October 20, 2025 12:27

Honny1 force-pushed the pr-multi-file-support-kube branch from 6e57e92 to 62c5e9b Compare October 20, 2025 18:19

mheon reviewed Oct 21, 2025

View reviewed changes

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 21, 2025

Honny1 force-pushed the pr-multi-file-support-kube branch from 62c5e9b to 9bda788 Compare October 22, 2025 10:11

Luap99 approved these changes Oct 22, 2025

View reviewed changes

openshift-ci bot assigned Luap99 Oct 22, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2025

openshift-merge-bot bot merged commit c15e845 into containers:main Oct 22, 2025
81 checks passed

Add multi-file support to podman kube play/down #27292

Add multi-file support to podman kube play/down #27292

Conversation

Honny1 commented Oct 14, 2025

Does this PR introduce a user-facing change?

Uh oh!

Honny1 commented Oct 14, 2025

Uh oh!

Honny1 commented Oct 14, 2025

Uh oh!

TomSweeneyRedHat Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

Honny1 Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

TomSweeneyRedHat commented Oct 15, 2025

Uh oh!

flouthoc Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

Honny1 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

flouthoc left a comment

Choose a reason for hiding this comment

Uh oh!

packit-as-a-service bot commented Oct 20, 2025

Uh oh!

Honny1 commented Oct 21, 2025

Uh oh!

mheon Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

mheon commented Oct 21, 2025

Uh oh!

mheon commented Oct 21, 2025

Uh oh!

Honny1 commented Oct 22, 2025

Uh oh!

Luap99 left a comment

Choose a reason for hiding this comment

Uh oh!

Luap99 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Luap99 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Oct 22, 2025

Uh oh!

Honny1 commented Oct 22, 2025

Uh oh!

Luap99 commented Oct 22, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add multi-file support to `podman kube play/down` #27292

Add multi-file support to `podman kube play/down` #27292