Skip to content

[Artifacts] Podman artifacts should support emitting events #27324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[Artifacts] Podman artifacts should support emitting events #27324

wants to merge 8 commits into from

Conversation

nimdrak
Copy link
Contributor

@nimdrak nimdrak commented Oct 20, 2025 •
edited
Loading

Does this PR introduce a user-facing change?

Fixed #27260

- Added support for artifact events in podman events. 
- Users can now monitor artifact operations (pull, push, add, remove, extract) using podman events --filter type=artifact. 
- This feature works with both journald and file event backends and displays artifact names, digests, and operation details.

e.g.

2025-10-20 13:14:31.887329296 +0000 UTC artifact push sha256:7886445a4f0d502f03b2bdb613ce21bf32edfb05b62a72012d9df5c1ea8b04d4 (name=localhost:5000/my-new-artifact:v1)
2025-10-20 12:55:42.436742074 +0000 UTC artifact pull sha256:a01e1070c4373bba02a9dd732b0eefd5edc5071ecd3a9d2eb537adc45c05031e (name=localhost:5000/my-practice-artifact:v1)
2025-10-20 13:14:06.619409258 +0000 UTC artifact add sha256:7886445a4f0d502f03b2bdb613ce21bf32edfb05b62a72012d9df5c1ea8b04d4 (name=localhost:5000/my-new-artifact:v1, files=1)
2025-10-20 12:56:22.641898967 +0000 UTC artifact extract  (name=localhost:5000/my-practice-artifact:v1, target=./extracted-files/)

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nimdrak
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nimdrak nimdrak marked this pull request as draft October 20, 2025 13:35
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@rhatdan rhatdan mentioned this pull request Oct 20, 2025
Open
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

mheon
mheon reviewed Oct 20, 2025
View reviewed changes
pkg/domain/infra/abi/artifact.go Outdated
}
return nil, err
}
ir.Libpod.NewArtifactEvent(events.Remove, "", namesOrDigest, nil)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should probably go in libartifact in containers/container-libs - pass it in when creating a new instance of an artifact store (at https://github.com/containers/container-libs/blob/main/common/pkg/libartifact/store/store.go#L50) and go from there

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! It looks much better.
How about this one? 83b6234.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
@nimdrak
Fixed containers#27260 Add new type and status in libpod/events/confi…
6f76f5e 
…g.go

Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260 Handle new type and status in libpod/events/ev…
d9c9be2 
…ents.go

Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260 Handle new type and status in libpod/events/jo…
8151bf9 
…urnal_linux.go

Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260 Handle new type and status in libpod/events/lo…
6eff968 
…gfile.go

Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260 Add NewArtifactEvent in libpod/events.go
bf597b1 
Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260: Use ir.Libpod.NewArtifactEvent
09b8ffb 
Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260: gofmt
3830616 
Signed-off-by: ByoungUk Lee <[email protected]>
@nimdrak
Fixed containers#27260 Use NewArtifactEvent by injecting dependency i…
83b6234 
…n NewArtifactStore

Signed-off-by: ByoungUk Lee <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mheon mheon mheon left review comments

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Artifacts] Podman artifacts should support emitting events

3 participants

@nimdrak @mheon @openshift-merge-robot