Eliminate network dependencies in podman search e2e tests with mock registry
#27333
Conversation
openshift-ci
bot
added
release-note-none
do-not-merge/work-in-progress
Honny1
force-pushed
the
search-tests-without-net
branch
from
1188b17 to
a5e82e5
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
test/e2e/search_test.go
Outdated
| search := podmanTest.Podman([]string{"search", "quay.io/podman/stable"}) | ||
| search.WaitWithDefaultTimeout() | ||
| Expect(search).Should(ExitCleanly()) | ||
| registryAddress, srv, serverErr := CreateMockRegistryServer() |
There was a problem hiding this comment.
Can this be done in a BeforeEach?
There was a problem hiding this comment.
Yes, I have changed the test to use BeforeEach and AfterEach.
test/e2e/search_mock_registry.go
Outdated
| contentTypeJSON = "application/json" | ||
| ) | ||
|
|
||
| var searchResults = map[string]interface{}{ |
There was a problem hiding this comment.
s/interface{}/any everywhere please
There was a problem hiding this comment.
please squash these changes into the proper commit where you added them, appending them into the last commit makes it harder to review commit for commit and isn't right, the interface{} syntax should not be introduced to begin with.
test/e2e/search_test.go
Outdated
| Expect(search).To(ExitWithError(125, "getting repository tags: fetching tags list: StatusCode: 404")) | ||
| Expect(search.OutputToStringArray()).To(BeEmpty()) | ||
| }) | ||
| Describe("podman search do not crash on public registries", func() { |
There was a problem hiding this comment.
I think we should really not do this anymore, any public dependency will bite us. You now make us depend on at least three different registries which can still fail if the registry is down.
At the very least this should be skipped on PRs but I rather not do this at all as part of the normal CI.
Honny1
force-pushed
the
search-tests-without-net
branch
from
de5401c to
49fc8ab
Compare
Honny1
force-pushed
the
search-tests-without-net
branch
from
49fc8ab to
fcb24aa
Compare
- Add comprehensive mock registry server for e2e search tests - Replace quay.io and other external registry calls with local mock - Improve test reliability by removing network dependencies - Maintain full test coverage with controlled mock data Fixes: containers#27304 Fixes: https://issues.redhat.com/browse/RUN-3623 Signed-off-by: Jan Rodák <[email protected]>
…leanly Signed-off-by: Jan Rodák <[email protected]>
Signed-off-by: Jan Rodák <[email protected]>
Honny1
force-pushed
the
search-tests-without-net
branch
from
fcb24aa to
af2d913
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
3 participants
This PR refactors the
podman searche2e tests to eliminate external network dependencies and improve test reliability by introducing a comprehensive mock registry server.Fixes: #27304
Fixes: https://issues.redhat.com/browse/RUN-3623
Does this PR introduce a user-facing change?