Show ingredient thumbnails for provenance-free stub nodes#18
Open
andyparsons wants to merge 1 commit into
Open
Show ingredient thumbnails for provenance-free stub nodes#18andyparsons wants to merge 1 commit into
andyparsons wants to merge 1 commit into
Conversation
… view Ingredient assertions (c2pa.ingredient*) embed a thumbnail reference even when the ingredient has no Content Credentials. This change resolves those thumbnails and displays them on stub nodes in the provenance tree. - ingredientThumbnailSrc(): handles both v2 (inline data) and v1 (JUMBF url pointing to a c2pa.thumbnail.* assertion in the parent manifest) - enrichThumbnails(): extended to also resolve identifier URIs inside ingredient thumbnail objects (v2 embedded case) - enrichThumbnailsViaPackagedSdk(): quick-check now also detects unresolved ingredient-embedded thumbnail identifiers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Deploy Preview for c2pa-conformulator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sherifhanna-google
approved these changes
May 14, 2026
Collaborator
sherifhanna-google
left a comment
sherifhanna-google
left a comment
There was a problem hiding this comment.
Tested and it works.
sherifhanna-google
requested changes
May 14, 2026
Collaborator
sherifhanna-google
left a comment
sherifhanna-google
left a comment
There was a problem hiding this comment.
Reverting approval: some samples do not surface thumbnails as intended. Investigating.
Collaborator
|
This PR still had an issue showing some thumbnails, e.g. from this image: Here's the thumbnail tree from PR18: 
And here it is after some fixes in PR19: 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data) and v1 (JUMBFurlpointing to ac2pa.thumbnail.*assertion in the parent manifest) thumbnail formats.enrichThumbnailsandenrichThumbnailsViaPackagedSdkto also handle ingredient-embedded thumbnail identifiers (v2 case).Test plan
🤖 Generated with Claude Code