Display signer certificate CN in provenance graph nodes#19
Open
sherifhanna-google wants to merge 6 commits into
Open
Display signer certificate CN in provenance graph nodes#19sherifhanna-google wants to merge 6 commits into
sherifhanna-google wants to merge 6 commits into
Conversation
… view Ingredient assertions (c2pa.ingredient*) embed a thumbnail reference even when the ingredient has no Content Credentials. This change resolves those thumbnails and displays them on stub nodes in the provenance tree. - ingredientThumbnailSrc(): handles both v2 (inline data) and v1 (JUMBF url pointing to a c2pa.thumbnail.* assertion in the parent manifest) - enrichThumbnails(): extended to also resolve identifier URIs inside ingredient thumbnail objects (v2 embedded case) - enrichThumbnailsViaPackagedSdk(): quick-check now also detects unresolved ingredient-embedded thumbnail identifiers Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Switched Overview tree node labels from claim generator tool names to the Common Name (CN) from the leaf certificate subject that signed the claim. If the asset's signature is validated using the ITL (Interactive Trust List) CA list, the display automatically falls back to showing the friendly Claim Generator name to avoid generic test CAs (e.g., "C2PA Test CA"). Unified this conditional resolution logic between the provenance graph nodes and the text narrative summaries. Cleaned up unused props. TAG=agy CONV=651fee74-60bb-4d72-9cf8-a4b9333578d9
✅ Deploy Preview for c2pa-conformulator ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…d flexible JUMBF path segment parsing Refactored OverviewPanel's ingredientThumbnailSrc utility to perform: 1. Cryptographic hash matching (t.hash) against local assertions. This completely bypasses casing, JUMBF folders, relative vs absolute URIs, or encoding mismatches. 2. Versatile path segment split fallback for JUMBF URLs, extracting the last leaf segment instead of relying on strict folder prefixes. TAG=agy CONV=651fee74-60bb-4d72-9cf8-a4b9333578d9
Exclude ingredient thumbnails (c2pa.thumbnail.ingredient) from matching as manifest-level claim thumbnails in OverviewPanel helpers (thumbnailSrc and manifestFormat). This prevents ingredient thumbnails from leaking into manifest cards, resolving the off-by-one circular shift layout bug across all provenance nodes in the Overview graph when a manifest has no own claim thumbnail. Added a robust Vitest integration test to fully assert this isolation behavior. TAG=agy CONV=651fee74-60bb-4d72-9cf8-a4b9333578d9
…fallback - Prioritized the child manifest's own cryptographic claim thumbnail over the parent's ingredient assertion thumbnail. - Falls back to parent-resolved ingredient thumbnail if the child manifest does not have its own. - Added comprehensive unit tests verifying precedence and fallback behaviors. TAG=agy CONV=651fee74-60bb-4d72-9cf8-a4b9333578d9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched Overview tree node labels from claim generator tool names to the Common Name (CN) from the leaf certificate subject that signed the claim.
If the asset's signature is validated using the ITL (Interactive Trust List) CA list, the display automatically falls back to showing the friendly Claim Generator name to avoid generic test CAs (e.g. 'C2PA Test CA').
Unified this conditional resolution logic between the provenance graph nodes and the text narrative summaries. Cleaned up unused props.
TAG=agy
CONV=651fee74-60bb-4d72-9cf8-a4b9333578d9