Skip to content

fix: Add more error handling#66

Merged
tmathern merged 29 commits into
gpeacock/pythonfrom
mathern/test-repro
May 14, 2025
Merged

fix: Add more error handling#66
tmathern merged 29 commits into
gpeacock/pythonfrom
mathern/test-repro

Conversation

@tmathern
Copy link
Copy Markdown
Collaborator

@tmathern tmathern commented May 12, 2025

  • Add a test signing v2 claims
  • Add missing error handling
  • Accordingly, add negative tests (for error handling)

@tmathern tmathern self-assigned this May 12, 2025
Comment thread tests/c2pa.py Outdated
Comment thread tests/c2pa.py Outdated
@tmathern tmathern changed the title fix: Repro a failure fix: Add more error handling May 13, 2025
@tmathern tmathern requested a review from gpeacock May 13, 2025 17:31
@tmathern tmathern marked this pull request as ready for review May 13, 2025 17:31
Copy link
Copy Markdown
Member

@gpeacock gpeacock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging these changes here, but I also need to get the changes I was doing into a real repo. none of this really belongs in c2pa_c.

@tmathern
Copy link
Copy Markdown
Collaborator Author

I'm fine with merging these changes here, but I also need to get the changes I was doing into a real repo. none of this really belongs in c2pa_c.

Isn't all that going to move to c2pa-python once the libs release is squared out?

@tmathern tmathern merged commit 62ec5f4 into gpeacock/python May 14, 2025
4 of 13 checks passed
@tmathern tmathern deleted the mathern/test-repro branch May 14, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants