fix(#145): ManifestSummary/Tooltip/Popover accessibility#146
Open
majornista wants to merge 8 commits into
Open
fix(#145): ManifestSummary/Tooltip/Popover accessibility#146majornista wants to merge 8 commits into
majornista wants to merge 8 commits into
Conversation
Tooltip component used in ManifestSummary should: 1. Trigger should be keyboard accessible as a button. 2. Trigger should be labeled by the Tooltip and the header. 3. Popover for Tooltip should expand on focus and close on blur. 4. Popover should hide with Escape key and toggle on Trigger click. 5. Fix text color contrast for --cai-secondary-color. 6. Fix color contrast for --cai-icon-fill 7. Add focus outline color and outline-offset to Tooltip button and View More 8. Use `<section>` with aria-labelledby for PanelSection. 9. Add role="heading" and a heading level for the .heading-text element within PanelSection 10. Add role="img" and appropriate aria-label for each of the Icons
|
Thank you @majornista - we were working on updates to the ManifestSummary during the initial PR, and I see that you have updated |
Implement keyboard accessibility for Popover trigger and make it more generic, so that a user only needs to worry about an aria-label for the cai-indicator, rather than the expand/collapse behavior as well.
emensch
force-pushed
the
main
branch
2 times, most recently
from
f0bbd4e to
d61dff1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Tooltip component used in ManifestSummary should:
<section>with aria-labelledby for PanelSection.Types of changes
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment