fix: Test coverage#115
Merged
Merged
Conversation
Contributor
alextrnnn
commented
Jun 6, 2025
alextrnnn
commented
- Add more unit tests (non-threaded)
…d for compatibility
tmathern
requested changes
Jun 6, 2025
Collaborator
tmathern
left a comment
tmathern
left a comment
There was a problem hiding this comment.
- Use the with statement on Reader in test_stream_read_string_stream and test_stream_read_string_stream_and_parse (also ensure more test diversity, so we cover more ways a developer may want to use the SDK)
- A typo to fix
- Rest looks good, thank you for diving into this!
tmathern
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.