fix: DLL hijacking vulnerability in c2patool (CAI-8608)#2031
Open
scouten-adobe wants to merge 3 commits into
Open
fix: DLL hijacking vulnerability in c2patool (CAI-8608)#2031scouten-adobe wants to merge 3 commits into
scouten-adobe wants to merge 3 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2031 +/- ##
=======================================
Coverage 77.70% 77.70%
=======================================
Files 176 176
Lines 44645 44645
=======================================
Hits 34691 34691
Misses 9954 9954 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tmathern
approved these changes
Apr 10, 2026
| #[cfg(windows)] | ||
| // SAFETY: no invariants to uphold; the argument is a valid constant. | ||
| unsafe { | ||
| windows_sys::Win32::System::LibraryLoader::SetDefaultDllDirectories( |
Contributor
There was a problem hiding this comment.
SetDefaultDllDirectories has a return value, a bool indicating success. Shouldn't the result of this call be checked then?
Should not fail, but while hardening...
…ediately with an error rather than silently continuing with an insecure DLL search path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.