fix: Improve archive APIs to be able to link archives to actions#2095
Open
tmathern wants to merge 3 commits into
Open
fix: Improve archive APIs to be able to link archives to actions#2095tmathern wants to merge 3 commits into
tmathern wants to merge 3 commits into
Conversation
tmathern
changed the title
gpeacock
reviewed
Apr 29, 2026
| } | ||
|
|
||
| let ingredient = reader.to_ingredient()?; | ||
| let archive_ingredient_id = reader.active_archive_ingredient_id(); |
Member
There was a problem hiding this comment.
we don't know if the saved id came from the label or the instanceId here. We should just save and restore the user assigned label here, and it should be done in reader.to_ingredient.()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
The recently added archive APIs simplify the handling of ingredient archives, but there is a bug where when those APIs are used, two ingredients can't be linked to actions when a Builder signs (see test scenario
test_two_ingredient_archives_link_distinctly_via_actions).This fixes that.
Checklist
TO DOitems (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.