fix: error with validation results on invalid manifest after verify after sign#2147
Open
ok-nick wants to merge 14 commits into
Open
fix: error with validation results on invalid manifest after verify after sign#2147ok-nick wants to merge 14 commits into
ok-nick wants to merge 14 commits into
Conversation
…ing hashes for c2pa manifests
Merging this PR will improve performance by 29.65%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | large-cbor-assertion/read |
69.6 ms | 50.6 ms | +37.57% |
| ⚡ | Simulation | wide-ingredients/read |
248.8 ms | 221.4 ms | +12.41% |
| ⚡ | Simulation | large-json-assertion/read |
65.4 ms | 46.4 ms | +40.93% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing ok-nick/verify-after-sign (a5cd586) with main (9fb5ef4)
Footnotes
-
64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
tmathern
reviewed
May 14, 2026
tmathern
reviewed
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes verify after sign so that it builds up the validation results and returns them in an err if deemed an invalid manifest. Additionally, skip verifying hashes when signing only c2pa manifests (no asset).
Should it be enabled by default? There is a performance implication. Perhaps validation should be enabled by default and hash verification disabled?
verify_after_signsetting #1875application/c2pawill attempt to validate hash bindings #1704