Skip to content

fix: Share reqwest HTTP clients#2152

Open
tmathern wants to merge 12 commits into
mainfrom
mathern/pool-reqwest
Open

fix: Share reqwest HTTP clients#2152
tmathern wants to merge 12 commits into
mainfrom
mathern/pool-reqwest

Conversation

@tmathern
Copy link
Copy Markdown
Contributor

@tmathern tmathern commented May 15, 2026

Changes in this pull request

  • Share reqwest clients (avoid client recreation and related memory consumption).

Checklist

  • This PR represents a single feature, fix, or change.
  • All applicable changes have been documented.
  • Any TO DO items (or similar) have been entered as GitHub issues and the link to that issue has been included in a comment.

@tmathern tmathern self-assigned this May 15, 2026
@tmathern tmathern added safe to test check-release Add this label to any PR to invoke a larger suite of tests. labels May 15, 2026
@tmathern tmathern requested review from gpeacock and ok-nick May 15, 2026 14:44
Comment thread sdk/src/assertions/uuid_assertion.rs
@tmathern tmathern marked this pull request as ready for review May 15, 2026 14:47
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 15, 2026

Merging this PR will not alter performance

✅ 30 untouched benchmarks
⏩ 64 skipped benchmarks1


Comparing mathern/pool-reqwest (8bdf883) with main (87243f6)

Open in CodSpeed

Footnotes

  1. 64 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Comment thread sdk/src/http/reqwest.rs Outdated
@tmathern tmathern requested a review from gpeacock May 15, 2026 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-release Add this label to any PR to invoke a larger suite of tests. safe to test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants