feat: allow RegExp validation patterns []#1622
Merged
Jared Jolton (jjolton-contentful) merged 1 commit intoMay 13, 2026
Merged
Conversation
57b0c74 to
e32f015
Compare
e32f015 to
2416d4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regexp.patternandprohibitRegexp.patternvalidations to accept JavaScriptRegExpvalues.RegExppatterns to CMA-safe{ pattern, flags }payloads before content type requests are created.flagsvalues override flags embedded in theRegExp.Description
This keeps the existing string-based validation shape intact while allowing migration scripts to pass a
RegExpinstance as thepatternvalue. The generated payload storesRegExp.sourceaspattern, includesRegExp.flagswhen no explicitflagsvalue is provided, and lets explicitflagsvalues win when both are present.Generated with Codex
Motivation and Context
Fixes #1178.
The previous string-only API requires awkward double escaping in migration scripts. Accepting
RegExpvalues lets users write the same expression they would normally use in JavaScript while preserving the CMA payload contract.PR Checklist
CONTRIBUTING.mdfileTest plan
npm run buildnpm run test:unitnpm run lintnpm run test:typescript-declaration