feat(richTextEditor): add stickytoolbaroffset as prop#1966
Open
Sam Ashley (sam-is-content) wants to merge 1 commit into
Open
feat(richTextEditor): add stickytoolbaroffset as prop#1966Sam Ashley (sam-is-content) wants to merge 1 commit into
Sam Ashley (sam-is-content) wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
hey Sam Ashley (@sam-is-content) 👋 |
Kudakwashe Mupeni (2wce)
approved these changes
Oct 30, 2025
Yves Rijckaert (YvesRijckaert)
requested changes
Oct 30, 2025
Contributor
Yves Rijckaert (YvesRijckaert)
left a comment
Yves Rijckaert (YvesRijckaert)
left a comment
There was a problem hiding this comment.
Before we merge let's see if it works within an iframe
|
Marking pull request as stale since there was no activity for 30 days |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stickyToolbarOffsetis currently a prop for theConnectedRichTextEditorbut not for theRichTextEditorwhich I understand as the one we should use for apps. I would like to addstickyToolbarOffsetas a prop of theRichTextEditorso that when a rich text field is used in an app, we can optionally have a sticky toolbar.Why am I doing this now?
I received a Zendesk ticket from a customer saying they like the new rich-text-versioning app but do not find it worth using because the toolbar is not sticky. Let's change that :)