[NT-1691] Add reference React Native implementation and Detox e2e testing#42
Conversation
Alex Freas (akfreas)
requested review from
François (Lp-Francois),
Maroun (maroun9t),
Maximilian Rauh (maxrawlinger) and
Charles Hudson (phobetron)
as code owners
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
|
This PR also includes changes from the previous PR. Please fix the conflict in the previous PR so we can merge that branch to |
Alex Freas (akfreas)
force-pushed
the
NT-1691-add-reference-impl-app-and-detox
branch
2 times, most recently
from
ec1b37e to
4321687
Compare
Alex Freas (akfreas)
force-pushed
the
NT-1691-add-reference-impl-app-and-detox
branch
from
9cd54fe to
ee75771
Compare
|
|
||
| engineStrict: true | ||
|
|
||
| nodeVersion: 16.20.0 |
There was a problem hiding this comment.
Instead of removing this, let's update it to the earliest still-supported LTS, which I believe is a v19 version.
There was a problem hiding this comment.
I think we can move it to v20, as that's the earliest one in maintenance. (20.19.5)
| if (error instanceof Error) | ||
| logger.error(`Failed to remove ${key} from AsyncStorage:`, error) | ||
| // eslint-disable-next-line no-console -- Logging storage errors for debugging | ||
| console.error(`Failed to remove ${key} from AsyncStorage:`, error) |
There was a problem hiding this comment.
You can also use the logger for debugging. You'll need to make sure your console itself is set to the level debug. Let's make sure we don't check in any console method calls in code that ships with the SDKs.
| "engines": { | ||
| "node": ">=18" |
There was a problem hiding this comment.
Could we omit this if we update the pnpm-workspace.yaml file?
There was a problem hiding this comment.
Yes, I think we can remove it once those changes are there
…tion package.json
Alex Freas (akfreas)
deleted the
NT-1691-add-reference-impl-app-and-detox
branch
2 participants
NT-1691 Add reference React Native implementation and Detox e2e testing
This adds:
We were unable to use Appium because React Native's autolinking system generates code referencing classes that don't exist in RN. This has not been fixed in 0.8x even with the new architecture. Detox uses the React Native CLI, which is a cleaner solution and doesn't rely on a built APK.