💡 refactor(state): Rearranging states and fixing pm2 issue#47
Merged
Charles Hudson (phobetron) merged 1 commit intoOct 20, 2025
Merged
Conversation
Charles Hudson (phobetron)
requested review from
François (Lp-Francois),
Maroun (maroun9t) and
Maximilian Rauh (maxrawlinger)
as code owners
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Charles Hudson (phobetron)
force-pushed
the
NT-1687_rearranging-states-and-fixing-pm2-issue
branch
from
b1fa951 to
2b25f7d
Compare
Moving the relevant states to the modules that rely on them most. This allows us to more easily separate Personalization and Analytics in the future, if that ever makes sense. However, `profile` may be updated twice if the customer sets the defaults for both personalization and analytics, since it applies to both. Also, while the Core code can remain oblivious to the two modules' individual states collections, SDKs that rely on core may still need to be aware of the structure of the defaults for both modules for the purposes of caching. NoClose [[NT-1687](https://contentful.atlassian.net/browse/NT-1687)]
Charles Hudson (phobetron)
force-pushed
the
NT-1687_rearranging-states-and-fixing-pm2-issue
branch
from
2b25f7d to
1c79f51
Compare
Charles Hudson (phobetron)
deleted the
NT-1687_rearranging-states-and-fixing-pm2-issue
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the relevant states to the modules that rely on them most. This allows us to more easily separate Personalization and Analytics in the future, if that ever makes sense.
However,
profilemay be updated twice if the customer sets the defaults for both personalization and analytics, since it applies to both. Also, while the Core code can remain oblivious to the two modules' individual states collections, SDKs that rely on core may still need to be aware of the structure of the defaults for both modules for the purposes of caching.NoClose
[NT-1687]