Skip to content

[NT-1754] Surface merge tag functionality in RN implementation#69

Merged
Alex Freas (akfreas) merged 5 commits into
mainfrom
NT-1754-determine-and-implement-rn-merge-tag-support
Nov 11, 2025
Merged

[NT-1754] Surface merge tag functionality in RN implementation#69
Alex Freas (akfreas) merged 5 commits into
mainfrom
NT-1754-determine-and-implement-rn-merge-tag-support

Conversation

@akfreas
Copy link
Copy Markdown
Collaborator

@akfreas Alex Freas (akfreas) commented Nov 5, 2025

NT-1754 Surface merge tag functionality in RN implementation

  • Use merge tag functionality in MergeTagScreen.tsx
  • Make available on main App screen
  • Update App.tsx, breaking into components

This provides a basic reference implementation for the merge tags in the main React Native implementation app. I have moved the "dev dashboard" functionality out of this PR, it will be reintroduced later on with another ticket.

Here's how the current implementation app looks now:

image

.join('')
}

export function MergeTagScreen({
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a huge file. we could also break it down. in utils and rendered components i guess. maybe we can also give bit description what its trying to achieve as its not that clear from first look.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I like the extensive documentation, the app may not be the best place to keep it. It's difficult for me to see how a customer would actually implement Rich Text with Merge Tags, due to the focus on having everything partitioned out and documented/tracked separately. It would be nice if we simply rendered the Rich Text with Merge Tags as it would be in a real-life implementation technically, not with real-life content, just bare-bones integration and rendering code.

@akfreas Alex Freas (akfreas) force-pushed the NT-1754-determine-and-implement-rn-merge-tag-support branch from da35d82 to f01b5c5 Compare November 7, 2025 15:07
@akfreas Alex Freas (akfreas) force-pushed the NT-1754-determine-and-implement-rn-merge-tag-support branch from f01b5c5 to 8e75e21 Compare November 11, 2025 09:52
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👷🏻 🏗️

@akfreas Alex Freas (akfreas) merged commit e28090e into main Nov 11, 2025
15 checks passed
@akfreas Alex Freas (akfreas) deleted the NT-1754-determine-and-implement-rn-merge-tag-support branch November 11, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants