Skip to content

feat: openAppDialog method #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Marco Reni (marcoreni) wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −0
Open

feat: openAppDialog method #2506

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35612ca
feat: openAppDialog method
marcoreni Mar 26, 2026
947fd52
fix: wrong id reference
marcoreni Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/dialogs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export default function createDialogs(channel: Channel, ids: IdsAPI): DialogsAPI
openConfirm: openSimpleDialog.bind(null, 'confirm'),
openPrompt: openSimpleDialog.bind(null, 'prompt'),
openExtension: openExtensionDialog,
openApp: openAppDialog,
openCurrentApp: openCurrentAppDialog,
openCurrent: openCurrentDialog,
selectSingleEntry: openEntitySelector.bind(null, 'Entry', false),
Expand Down Expand Up @@ -57,6 +58,19 @@ export default function createDialogs(channel: Channel, ids: IdsAPI): DialogsAPI
}
}

function openAppDialog(options?: OpenCustomWidgetOptions) {
options = prepareOptions(options)

// Use provided ID, default to the current app.
options = { ...options, id: options?.id || ids.app }
if (options.id) {
// Force ID of the current app.
return channel.call('openDialog', 'app', options)
} else {
throw new Error('App ID not provided.')
}
}

function openCurrentAppDialog(options?: Omit<OpenCustomWidgetOptions, 'id'>) {
options = prepareOptions(options)
if (ids.app) {
Expand Down
2 changes: 2 additions & 0 deletions lib/types/dialogs.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ export interface DialogsAPI {
) => Promise<string | boolean>
/** Opens an extension in a dialog. */
openExtension: (options: OpenCustomWidgetOptions) => Promise<any>
/** Opens an app dialog */
openApp: (options?: OpenCustomWidgetOptions) => Promise<any>
/** Opens the current app in a dialog */
openCurrentApp: (options?: Omit<OpenCustomWidgetOptions, 'id'>) => Promise<any>
/** Opens the current app or extension in a dialog */
Expand Down