Skip to content

fix(vscode): cap and chunk file search initialization to prevent event loop starvation (#13249) #13271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maoxin1234 wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −6
Open

fix(vscode): cap and chunk file search initialization to prevent event loop starvation (#13249) #13271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions extensions/vscode/src/util/FileSearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import * as vscode from "vscode";

type FileMiniSearchResult = { relativePath: string; id: string };

export const MAX_FILE_SEARCH_FILES = 50_000;
export const FILE_SEARCH_BATCH_SIZE = 1_000;

/*
id = file URI
*/
Expand Down Expand Up @@ -35,12 +38,23 @@ export class FileSearch {
const results = await walkDirs(this.ide, {
source: "file search initialization",
});
this.miniSearch.addAll(
results.flat().map((uri) => ({
id: uri,
relativePath: vscode.workspace.asRelativePath(uri),
})),
);
const flatResults = results.flat();
const cappedResults =
flatResults.length > MAX_FILE_SEARCH_FILES
? flatResults.slice(0, MAX_FILE_SEARCH_FILES)
: flatResults;

for (let i = 0; i < cappedResults.length; i += FILE_SEARCH_BATCH_SIZE) {
const batch = cappedResults
.slice(i, i + FILE_SEARCH_BATCH_SIZE)
.map((uri) => ({
id: uri,
relativePath: vscode.workspace.asRelativePath(uri),
}));
this.miniSearch.addAll(batch);
// Yield to event loop to keep the extension host and renderer responsive
await new Promise((resolve) => setTimeout(resolve, 0));
}
}

public search(query: string): FileMiniSearchResult[] {
Expand Down
Loading