Fix two bugs introduced by previous updates for VertexAI #4016
+59
−117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for continuedev canceled.
|
|
Can you add a test in llm.test.ts for the Vertex class? Shouldn't take much, just about 5 lines of code |
Lash-L
changed the title
Hi are you looking for a TestLLM call? Or something else? |
|
Hey @sestinj - sorry for the ping - just trying to figure out what kind of tests you would like to see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening this in place of #3711 as it fixes all of the relevant problems instead of just one.
Seems like a bug was introduced when the embeddings were merged into the llm.
b14b8c4#diff-f6056e365b00006d0872276e5078b8e10b940dfeca7f0aa106b1c842e5aa5a14
The embedding class's base url didn't have a slash at the end, while the llm one did. Neither one was 'wrong', but they were different, so when it was merged, it ended up having a // in the url.
Removing the / before the embedding url fixes this problem.
As well, a bug was introduced in 3b25f78 that broke sending messages as it took the options out of the needed subsection.
Gemini via AI studio and VertexAI are very very similar. So I extracted out the logic that could be copied from the vertexai send and I now call it in VertexAI. This should help prevent any future issues and allow vertexAI's gemini deployment to piggyback on gemini's.
Checklist
Screenshots
[ For visual changes, include screenshots. ]
Testing instructions
[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]