Fix context item deduplication logic and add text truncation to context peek #6429
Conversation
✅ Deploy Preview for continuedev canceled.
|
dosubot
bot
added
the
size:S
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
cubic reviewed 2 files and found no issues. Review PR in cubic.dev.
| </span> | ||
| <div | ||
| className={`group flex flex-row items-center gap-1.5 pr-1.5 text-xs text-gray-400 ${isUrl ? "hover:underline" : ""}`} | ||
| className={`group flex flex-row items-center gap-1.5 truncate pr-1.5 text-xs text-gray-400 ${isUrl ? "hover:underline" : ""}`} |
There was a problem hiding this comment.
line-clamp-1 preferred if possible
| item.uri && | ||
| i.uri.type === item.uri.type && | ||
| i.uri.value === item.uri.value), | ||
| i.id.providerTitle === item.id.providerTitle && |
There was a problem hiding this comment.
Requested changes for this line
It changes deduplication to be for exactly the same context item but breaks it for the original goal which is e.g. openFiles and currentFile adds the same file twice, or @diff is mentioned three times in nested prompts, or @openfiles in a prompt matches a @file mention in the editor, etc.
There was a problem hiding this comment.
But I realized deduplication logic had another flaw which is that you can have multiple context items with the same file URI and different content
Maybe the solution is as simple as
i.content === item.content
|
no longer needed after the changes from jazzcourt |
itemId isn't necessarily unique, so this was necessary to avoid items being removed. This was causing docs to not work for example (only one result returned)