fix: migrate proxy pooling activity to project activity #7609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
💡 To request a new review, comment |
I fixed this because since bumping the platform version we were getting an exception on startup about a required migration. Solves: com.intellij.diagnostic.PluginException: Migrate com.github.continuedev.continueintellijextension.proxy.ProxyPoolingActivity to ProjectActivity [Plugin: com.github.continuedev.continueintellijextension] at com.intellij.ide.startup.impl.StartupManagerImpl.runPostStartupActivities(StartupManagerImpl.kt:275) at com.intellij.ide.startup.impl.StartupManagerImpl.access$runPostStartupActivities(StartupManagerImpl.kt:68) at com.intellij.ide.startup.impl.StartupManagerImpl$runPostStartupActivities$3$2.invokeSuspend(StartupManagerImpl.kt:191) Note: the new activity is asynchronous, so we don't need to create our own coroutine scope for polling the settings. I tested this feature manually (change in settings is properly recognized & binary restarts on apply).
Patrick-Erichsen
approved these changes
Sep 5, 2025
Patrick-Erichsen
approved these changes
Sep 5, 2025
|
@exigow looks like some failure is causing the jetbrains tests to be skipped |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves:
I fixed this because since bumping the platform version we were getting an exception on startup about a required migration.
Note: the new activity is asynchronous, so we don't need to create our own coroutine scope for polling the settings.
I tested this feature manually (change in settings is properly recognized & binary restarts on apply).
Summary by cubic
Migrated proxy polling from StartupActivity to ProjectActivity to fix the startup exception after the platform bump. Behavior is unchanged: settings changes are detected and the core restarts.