Skip to content

Conversation

@sestinj
Copy link
Contributor

@sestinj sestinj commented Sep 11, 2025

Description

improvements to find and replace


Summary by cubic

Improves the Find and Replace experience with inline diff stats, clearer messages, and a cleaner tool call header. Simplifies tool copy, always shows a scrollbar, and adds model info to tool call telemetry.

  • UI Improvements

    • Find & Replace: show +/− line counts in the header, left-align the ellipsis, and display a friendly “string not found” message.
    • Always show a thin scrollbar; removed the “Show Chat Scrollbar” setting.
    • Simplified tool call header: removed args and truncate-history buttons; shorter status text (“will”, “wants to”).
    • Shortened tool messages across built-ins (Create File, Read URL/File/Range/Current, Glob, Grep, ls, Find and Replace).
  • Telemetry

    • Include the selected model in PostHog events for tool call decisions (auto-accept/accept/reject) and outcomes.

@sestinj sestinj requested a review from a team as a code owner September 11, 2025 04:37
@sestinj sestinj requested review from tomasz-stefaniak and removed request for a team September 11, 2025 04:37
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Sep 11, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 17 files

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

);

const showScrollbar = showChatScrollbar ?? window.innerHeight > 5000;
const showScrollbar = true;
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hardcoding showScrollbar to true ignores the ui.showChatScrollbar configuration and forces the thin-scrollbar UI regardless of user settings.

Prompt for AI agents
Address the following comment on gui/src/pages/gui/Chat.tsx at line 382:

<comment>Hardcoding showScrollbar to true ignores the ui.showChatScrollbar configuration and forces the thin-scrollbar UI regardless of user settings.</comment>

<file context>
@@ -381,7 +379,7 @@ export function Chat() {
   );
 
-  const showScrollbar = showChatScrollbar ?? window.innerHeight &gt; 5000;
+  const showScrollbar = true;
 
   return (
</file context>

✅ Addressed in fcbe5bc

const selectedChatModel = selectSelectedChatModel(state);

posthog.capture("gui_tool_call_decision", {
model: selectedChatModel,
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot Sep 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry event may include an undefined model because the null-check happens after this capture; consider providing a fallback value or moving the check earlier.

Prompt for AI agents
Address the following comment on gui/src/redux/thunks/callToolById.ts at line 49:

<comment>Telemetry event may include an undefined model because the null-check happens after this capture; consider providing a fallback value or moving the check earlier.</comment>

<file context>
@@ -43,14 +43,15 @@ export const callToolById = createAsyncThunk&lt;
+  const selectedChatModel = selectSelectedChatModel(state);
+
   posthog.capture(&quot;gui_tool_call_decision&quot;, {
+    model: selectedChatModel,
     decision: isAutoApproved ? &quot;auto_accept&quot; : &quot;accept&quot;,
     toolName: toolCallState.toolCall.function.name,
</file context>
Suggested change
model: selectedChatModel,
model: selectedChatModel ?? "unknown",
Fix with Cubic

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@continuedev does this make sense?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've started a remote session to help with your request:

@continuedev does this make sense?

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RomneyDa
Copy link
Collaborator

@sestinj any specific reason for removing chat scrollbar? https://github.com/continuedev/continue/issues?q=is%3Aissue%20chat%20scrollbar

personally I find the scrollbar pretty ugly/jarring

@sestinj
Copy link
Contributor Author

sestinj commented Sep 12, 2025

Avg chat is longer these days with agent mode it seems, and I've found myself wanting it more often. Doesn't need to change though if there's a strong opinions the other way

@sestinj sestinj merged commit 3ebd823 into main Sep 15, 2025
56 checks passed
@sestinj sestinj deleted the nate/improve-find-replace branch September 15, 2025 18:19
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Sep 15, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 15, 2025
@github-actions github-actions bot added the tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys label Sep 15, 2025
@sestinj
Copy link
Contributor Author

sestinj commented Sep 16, 2025

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

released size:L This PR changes 100-499 lines, ignoring generated files. tier 2 Important feature that adds new capabilities to the platform or improves critical user journeys

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants