- 
                Notifications
    
You must be signed in to change notification settings  - Fork 3.7k
 
feat: improvements to find and replace #7701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 issues found across 17 files
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
        
          
                gui/src/pages/gui/Chat.tsx
              
                Outdated
          
        
      | ); | ||
| 
               | 
          ||
| const showScrollbar = showChatScrollbar ?? window.innerHeight > 5000; | ||
| const showScrollbar = true; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcoding showScrollbar to true ignores the ui.showChatScrollbar configuration and forces the thin-scrollbar UI regardless of user settings.
Prompt for AI agents
Address the following comment on gui/src/pages/gui/Chat.tsx at line 382:
<comment>Hardcoding showScrollbar to true ignores the ui.showChatScrollbar configuration and forces the thin-scrollbar UI regardless of user settings.</comment>
<file context>
@@ -381,7 +379,7 @@ export function Chat() {
   );
 
-  const showScrollbar = showChatScrollbar ?? window.innerHeight > 5000;
+  const showScrollbar = true;
 
   return (
</file context>
✅ Addressed in fcbe5bc
| const selectedChatModel = selectSelectedChatModel(state); | ||
| 
               | 
          ||
| posthog.capture("gui_tool_call_decision", { | ||
| model: selectedChatModel, | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Telemetry event may include an undefined model because the null-check happens after this capture; consider providing a fallback value or moving the check earlier.
Prompt for AI agents
Address the following comment on gui/src/redux/thunks/callToolById.ts at line 49:
<comment>Telemetry event may include an undefined model because the null-check happens after this capture; consider providing a fallback value or moving the check earlier.</comment>
<file context>
@@ -43,14 +43,15 @@ export const callToolById = createAsyncThunk<
+  const selectedChatModel = selectSelectedChatModel(state);
+
   posthog.capture("gui_tool_call_decision", {
+    model: selectedChatModel,
     decision: isAutoApproved ? "auto_accept" : "accept",
     toolName: toolCallState.toolCall.function.name,
</file context>
| model: selectedChatModel, | |
| model: selectedChatModel ?? "unknown", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@continuedev does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've started a remote session to help with your request:
@continuedev does this make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sestinj any specific reason for removing chat scrollbar?
https://github.com/continuedev/continue/issues?q=is%3Aissue%20chat%20scrollbar
          
 personally I find the scrollbar pretty ugly/jarring  | 
    
| 
           Avg chat is longer these days with agent mode it seems, and I've found myself wanting it more often. Doesn't need to change though if there's a strong opinions the other way  | 
    
| 
           🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀  | 
    
Description
improvements to find and replace
Summary by cubic
Improves the Find and Replace experience with inline diff stats, clearer messages, and a cleaner tool call header. Simplifies tool copy, always shows a scrollbar, and adds model info to tool call telemetry.
UI Improvements
Telemetry