Skip to content

Conversation

RomneyDa
Copy link
Collaborator

@RomneyDa RomneyDa commented Sep 11, 2025

…l error
Before:
duplicate fatal error notices
image

no fatal error explanation
image

After:
removes duplicate
image

shows fatal errors in config agents section
image

Description

[ What changed? Feel free to be brief. ]

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes duplicate fatal error banners and shows configuration errors for the selected assistant in the Agents section, so users see a single, clear error with details. Addresses CON-3899.

  • Bug Fixes
    • Display config errors for the active assistant by using store-backed errors when the profile is selected.
    • Remove duplicate fatal error notice by only rendering the global indicator outside the chat route (chat keeps its own indicator).

@RomneyDa RomneyDa requested a review from a team as a code owner September 11, 2025 21:41
@RomneyDa RomneyDa requested review from tomasz-stefaniak and removed request for a team September 11, 2025 21:41
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Sep 11, 2025
Copy link

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.


💡 To request a new detailed review, comment @continue-detailed-review

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 2 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="gui/src/components/Layout.tsx">

<violation number="1" location="gui/src/components/Layout.tsx:284">
FatalErrorIndicator will still show on /index.html (Chat) because the condition only excludes &quot;/&quot;; also exclude &quot;/index.html&quot; to avoid duplicate fatal error notices on the chat page.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 11, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Sep 11, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 11, 2025
@RomneyDa RomneyDa merged commit 761f884 into main Sep 12, 2025
56 checks passed
@RomneyDa RomneyDa deleted the dallin/con-3899-fatal-errors-not-showing branch September 12, 2025 17:31
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Sep 12, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2025
@sestinj
Copy link
Contributor

sestinj commented Sep 16, 2025

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm This PR has been approved by a maintainer released size:L This PR changes 100-499 lines, ignoring generated files.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants