Add HamiltonianSystem with AD support and AugmentedHamiltonianTrait#229
Merged
Conversation
Member
ocots
commented
May 19, 2026
ocots
commented
- Add AugmentedHamiltonianTrait and AbstractAugmentedHamiltonianConfig in Common module
- Update AbstractHamiltonianSystem to include AD trait parameter (AT)
- Add HamiltonianSystem struct with AD backend support, mirroring HamiltonianVectorFieldSystem
- Implement build_rhs_augmented with batch compatibility checks for matrix inputs
- Add build_system overloads for Data.Hamiltonian with AD backend
- Update all references to AbstractHamiltonianSystem to include AT parameter:
- AbstractHamiltonianFlow in Flows
- MultiPhaseHamiltonianFlow in MultiPhase
- All test files with fake Hamiltonian systems
- Add comprehensive docstrings following documentation standards
- Add tests for HamiltonianSystem, ad_trait, build_rhs_augmented, and type stability
- All 1786 tests passing
- Add AugmentedHamiltonianTrait and AbstractAugmentedHamiltonianConfig in Common module - Update AbstractHamiltonianSystem to include AD trait parameter (AT) - Add HamiltonianSystem struct with AD backend support, mirroring HamiltonianVectorFieldSystem - Implement build_rhs_augmented with batch compatibility checks for matrix inputs - Add build_system overloads for Data.Hamiltonian with AD backend - Update all references to AbstractHamiltonianSystem to include AT parameter: - AbstractHamiltonianFlow in Flows - MultiPhaseHamiltonianFlow in MultiPhase - All test files with fake Hamiltonian systems - Add comprehensive docstrings following documentation standards - Add tests for HamiltonianSystem, ad_trait, build_rhs_augmented, and type stability - All 1786 tests passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.