Extract traits configs#235
Merged
Merged
Conversation
- Create new Traits module with trait types and functions - Add 9 orthogonal test files mirroring source structure - Update trait fallback methods to throw IncorrectArgument instead of NotImplemented - Comment out includes for abstract_trait.jl and traits.jl in Common.jl - Add abstract_cache.jl to Common module - Delete old Common trait test files (test_abstract_trait.jl, test_traits.jl)
… types - Created new Traits.jl module with OCP reexports - Removed trait exports from Common.jl - Qualified all trait types with Traits. in docstrings and function signatures - Updated all module manifests to import Traits - Fixed trait accessor calls to use Traits. instead of Common. or Flows. - Changed Solutions.final_state/times/evaluate_at to Integrators.final_state/times/evaluate_at - Added Integrators import to CTFlowsPlots extension - Fixed _oop_arity function signatures with type parameters - All 1,696 tests pass (common: 233, data: 312, systems: 273, flows: 320, multiphase: 238, integrators: 38, extensions: 482) - Deleted obsolete files: abstract_trait.jl, traits.jl, test_variable_costate.jl
- Create new src/Configs/ submodule with abstract.jl, interface.jl, implementations.jl, concrete.jl, show.jl - Move all config types (AbstractConfig, StatePointConfig, StateTrajectoryConfig, HamiltonianPointConfig, HamiltonianTrajectoryConfig, AugmentedHamiltonianPointConfig, AugmentedHamiltonianTrajectoryConfig) from Common to Configs - Update src/CTFlows.jl to include Configs in correct topological order - Remove config definitions from src/Common/Common.jl and delete src/Common/configs.jl - Update all source modules (Flows, Integrators, Solutions, MultiPhase) to reference Configs - Update ext/CTFlowsSciML/ to reference Configs - Update all test files to import CTFlows.Configs and use Configs.* for config types - Fix scalarize and variable function references to Common (they remain in Common) - Update docstrings in Traits and Common to reference Configs instead of Common - All 1,825 tests pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.