Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/JuMPModels/bioreactor.jl
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ julia> model = OptimalControlProblems.bioreactor(JuMPBackend(); N=100)

- [control-toolbox/bocop](https://github.com/control-toolbox/bocop/tree/main/bocop)
"""
function OptimalControlProblems.bioreactor(::JuMPBackend; N::Int=500)
function OptimalControlProblems.bioreactor(::JuMPBackend; N::Int=600)

# parameters
β = 1
Expand Down
2 changes: 1 addition & 1 deletion ext/MetaData/bioreactor.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
bioreactor_meta = OrderedDict(
:name => "bioreactor",
:N => 500,
:N => 600,
:minimise => false,
:state_name => ["y", "s", "b"],
:costate_name => ["∂y", "∂s", "∂b"],
Expand Down
2 changes: 1 addition & 1 deletion ext/OptimalControlModels/bioreactor.jl
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ NLP model corresponding to the Bioreactor problem

- BOCOP repository: https://github.com/control-toolbox/bocop/tree/main/bocop
"""
function OptimalControlProblems.bioreactor(::OptimalControlBackend; N::Int=500)
function OptimalControlProblems.bioreactor(::OptimalControlBackend; N::Int=600)

# METHANE PROBLEM
# μ2 according to growth model
Expand Down
Binary file modified test/figures/init/bioreactor.pdf
Binary file not shown.
Binary file modified test/figures/solution/bioreactor.pdf
Binary file not shown.
2 changes: 1 addition & 1 deletion test/runtests.jl
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ end
# list_of_problems = setdiff(list_of_problems, problems_to_exclude)

# list_of_problems = [
# :space_shuttle
# :bioreactor
# ]

# The list of all the problems to test
Expand Down
2 changes: 1 addition & 1 deletion test/test_OptimalControl.jl
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function test_OptimalControl()
keep_problem = true

#
DEBUG && println("\n", "┌─ ", string(f), " (JuMP)")
DEBUG && println("\n", "┌─ ", string(f), " (OptimalControl)")
DEBUG && println("│")

# Set up the model
Expand Down
4 changes: 0 additions & 4 deletions test/utils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -296,10 +296,6 @@ function comparison(; max_iter, test_name)
L2_bd = max(0.5*(L2_oc + L2_jp)*ε_rel_control, ε_abs_control)
res = @my_test_broken L2_di < L2_bd

if f != :bioreactor # the test does not pass on GitHub CI
keep_problem = keep_problem && (typeof(res) == Test.Pass)
end

DEBUG && println("├─ control $(u_vars[i])")
DEBUG && println("│")
DEBUG && println("│ L2 oc = ", L2_oc)
Expand Down
Loading