Add Open Cluster Scheduler / Gridware Cluster Scheduler to the grid#6
Add Open Cluster Scheduler / Gridware Cluster Scheduler to the grid#6dgruber wants to merge 2 commits into
Conversation
|
You could test with this: https://github.com/hpc-gridware/quickinstall/tree/main/containers/openSUSE/15.6 |
|
Awesome! I will test this soon. |
|
Ran into an issue with testing: hpc-gridware/quickinstall#10 (posting cross-reference for easy access / provenance)! |
vsoch
left a comment
There was a problem hiding this comment.
This looks great! Can confirm I can detect it in the docker compose environment.
If you are able to find Handles discovery and status for the SGE-family schedulers: and replace the : with a . we can consider that a bug fix. Does this have any commands to dispatch (for example, submit, job info, cancel, etc.)?
| """ | ||
| if not self.bin_path: | ||
| return {"installed": False} | ||
| return { |
There was a problem hiding this comment.
Any chance this might change, so it would be advisable to set as instance class properties instead of discovering dynamically?
There was a problem hiding this comment.
Did you answer this question about the environment variables? Any reason to not set on probe?
| str: Output of 'qhost'. Use this to see physical capacity and | ||
| current load before proposing a job. | ||
| """ | ||
| tool = shutil.which("qhost") |
There was a problem hiding this comment.
We might want to set this on probe too.
There was a problem hiding this comment.
I would have it set as an attribute so in the subsequent functions you can just reference self.qconf
|
@vsoch sorry for the late response and thanks for your comments. Added caching, removed the colon, and added the dispatch tool. |
| """ | ||
| if not self.bin_path: | ||
| return {"installed": False} | ||
| return { |
There was a problem hiding this comment.
Did you answer this question about the environment variables? Any reason to not set on probe?
| return self.run_workload_cmd([self.qconf, "-spl"]) if self.qconf else "qconf not found" | ||
|
|
||
| @dispatch_tool | ||
| def submit_job(self, arguments: str) -> str: |
There was a problem hiding this comment.
Is there any kind of validation checks you want to do before submission?
No description provided.