Skip to content

feat/goal-custom-dimensions #318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbaseya merged 3 commits into from
Jul 28, 2025
Merged

feat/goal-custom-dimensions #318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35dba11
feat: Add support for custom dimensions when tracking conversions
abbaseya Jul 26, 2025
a77e7bc
chore: update generated config types
abbaseya Jul 26, 2025
db55386
chore: update config types for custom dimensions
abbaseya Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .prettierignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
node_modules
CHANGELOG.md
packages/types/src/config
7 changes: 6 additions & 1 deletion packages/enums/src/goal-data-key.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,10 @@
export enum GoalDataKey {
AMOUNT = 'amount',
PRODUCTS_COUNT = 'productsCount',
TRANSACTION_ID = 'transactionId'
TRANSACTION_ID = 'transactionId',
CUSTOM_DIMENSION_1 = 'customDimension1',
CUSTOM_DIMENSION_2 = 'customDimension2',
CUSTOM_DIMENSION_3 = 'customDimension3',
CUSTOM_DIMENSION_4 = 'customDimension4',
CUSTOM_DIMENSION_5 = 'customDimension5'
Comment thread
abbaseya marked this conversation as resolved.
}
6 changes: 3 additions & 3 deletions packages/types/src/config/types.gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2529,11 +2529,11 @@ export type ConversionEvent = {
/**
* Key of the metric
*/
key?: 'amount' | 'productsCount' | 'transactionId';
key?: 'amount' | 'productsCount' | 'transactionId' | 'customDimension1' | 'customDimension2' | 'customDimension3' | 'customDimension4' | 'customDimension5';
/**
* Value of the metric
*/
value?: (number | string);
value?: (number | string | Array<string>);
}>;
/**
* Bucketing data (experiences that this visitor is currently part of) for the visitor. In case that **enrichData=true** flag is being sent and
Expand Down Expand Up @@ -2830,4 +2830,4 @@ export type $OpenApiTs = {
};
};
};
};
};