Skip to content

Pre-release - #340

Merged
JosephSamirL merged 11 commits into
mainfrom
main-convert
Nov 12, 2025
Merged

Pre-release#340
JosephSamirL merged 11 commits into
mainfrom
main-convert

Conversation

@abbaseya

Copy link
Copy Markdown
Collaborator

No description provided.

@abbaseya abbaseya self-assigned this Nov 12, 2025
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @abbaseya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive update of project dependencies across various demo applications and core SDK modules. It also includes important structural and functional enhancements, such as migrating the ESLint configuration to ES modules, introducing an SDK wrapper for Next.js to better handle ESM, and refining the SDK's type definitions to support new features and improve clarity. The changes aim to modernize the codebase, ensure compatibility with the latest ecosystem tools, and lay groundwork for future SDK capabilities, particularly around visitor data management.

Highlights

  • Dependency Updates: Numerous dependencies across all demo projects (NestJS, Next.js, Node.js, ReactJS, RemixJS) and core SDK packages have been updated to their latest versions. This includes major updates for NestJS (v9 to v11), Next.js (v14 to v16), React (v18 to v19), and Remix (v2 to v2.17).
  • Next.js Demo Enhancements: The Next.js demo project received several configuration updates, including changes to middleware.js, next-env.d.ts, next.config.mjs, and postcss.config.mjs. A new sdkWrapper has been introduced to facilitate ESM imports for the Convert SDK, and the tsconfig.json has been updated for modern TypeScript features.
  • ESLint Configuration Migration: The root ESLint configuration file has been renamed from eslint.config.js to eslint.config.mjs and migrated to use ES module syntax, aligning with modern JavaScript practices.
  • SDK Type Definition Refinements: The packages/types/src/config/types.gen.ts file has undergone significant updates. This includes adding new types like VisitorDataExistsMatchRulesTypes, UploadedFileData, ConcurrencyKey, and ExperienceChangeServing, along with enhanced JSDoc comments for improved clarity and detail across many existing types. New API endpoints for visitor data have also been introduced.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a large pre-release update, primarily focused on upgrading dependencies across the entire monorepo. This includes major version bumps for key libraries like Next.js, React, and Express. Alongside dependency updates, there are numerous code formatting fixes, a migration to ESLint's flat config, and significant enhancements to the auto-generated API type definitions in packages/types. These type changes introduce new features like visitor data endpoints and optimistic locking, and also improve the existing documentation.

My review has identified a couple of medium-severity issues:

  1. A workaround in the React demo to disable ESLint, which impacts code quality checks.
  2. An inconsistent comment in the auto-generated types that should be corrected for clarity.

Overall, the changes are positive and move the project forward, but the identified issues should be addressed to maintain code quality and documentation accuracy.

Comment thread demo/reactjs/package.json
Comment thread packages/types/src/config/types.gen.ts
@sonarqubecloud

sonarqubecloud Bot commented Nov 12, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@abbaseya
abbaseya requested a review from a team November 12, 2025 07:38
@JosephSamirL
JosephSamirL merged commit f9d69b6 into main Nov 12, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants