Skip to content

fix/sync-main #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbaseya merged 15 commits into from
Nov 12, 2025
Merged

fix/sync-main #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
858699a
Merge pull request #329 from convertcom/main-convert
abbaseya Sep 5, 2025
aa56b01
chore: Update release-please-action
abbaseya Sep 5, 2025
5cdfb11
fix: Improve numeric check utility
abbaseya Sep 5, 2025
1d6374a
Merge pull request #331 from convertcom/fix/releas-please
abbaseya Sep 5, 2025
e1ab4ea
chore: release main
github-actions[bot] Sep 5, 2025
d9747dc
Merge pull request #330 from convertcom/release-please--branches--main
abbaseya Sep 5, 2025
75f8c5c
chore: Integrate npm publish into release-please-action
abbaseya Sep 5, 2025
cdc4278
chore: fix release-pelease-action path
abbaseya Sep 5, 2025
7487a92
Merge branch 'main' into fix/release-please-action-npm-publish
abbaseya Sep 5, 2025
6afc034
Merge pull request #332 from convertcom/fix/release-please-action-npm…
JosephSamirL Sep 8, 2025
43acf62
chore: Manual npm publish requiring input tags
abbaseya Sep 8, 2025
b97d948
Merge pull request #333 from convertcom/fix/release-please-action-npm…
abbaseya Sep 8, 2025
0f2ab5b
chore: fix broken package publish workflow
abbaseya Sep 8, 2025
1672b2a
Merge pull request #334 from convertcom/fix/release-please-action-npm…
abbaseya Sep 8, 2025
c227d53
Merge branch 'main' into fix/sync-main
abbaseya Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 22 additions & 15 deletions .github/workflows/publish-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,86 +2,93 @@ name: Publish Package to npmjs
on:
release:
types: [published]
workflow_dispatch:
inputs:
tag:
description: 'Tag to publish (e.g. js-sdk-v4.3.3, js-sdk-utils-v2.2.3)'
required: true
jobs:
build:
publish:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
# Setup .npmrc file to publish to npm
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: '18.x'
registry-url: 'https://registry.npmjs.org'
- name: Resolve tag
run: echo "RELEASE_TAG=${{ github.event.release.tag_name || inputs.tag }}" >> $GITHUB_ENV
- run: |
yarn set version berry
yarn
- if: ${{ startsWith(github.event.release.name, 'js-sdk-enums:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-enums-v') }}
run: |
yarn enums:build
(cd packages/enums && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-types:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-types-v') }}
run: |
yarn types:build
(cd packages/types && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-utils:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-utils-v') }}
run: |
yarn utils:build
(cd packages/utils && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-event:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-event-v') }}
run: |
yarn event:build
(cd packages/event && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-bucketing:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-bucketing-v') }}
run: |
yarn bucketing:build
(cd packages/bucketing && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-logger:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-logger-v') }}
run: |
yarn logger:build
(cd packages/logger && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-rules:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-rules-v') }}
run: |
yarn rules:build
(cd packages/rules && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-segments:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-segments-v') }}
run: |
yarn segments:build
(cd packages/segments && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-api:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-api-v') }}
run: |
yarn api:build
(cd packages/api && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-data:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-data-v') }}
run: |
yarn data:build
(cd packages/data && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk-experience:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-experience-v') }}
run: |
yarn experience:build
(cd packages/experience && npm publish --access public)
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
- if: ${{ startsWith(github.event.release.name, 'js-sdk:') }}
- if: ${{ startsWith(env.RELEASE_TAG, 'js-sdk-v') }}
run: |
yarn sdk:build
(cd packages/js-sdk && npm publish --access public)
Expand Down
44 changes: 43 additions & 1 deletion .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,50 @@ permissions:
jobs:
release:
runs-on: ubuntu-latest
outputs:
releases_created: ${{ steps.release.outputs.releases_created }}
paths_released: ${{ steps.release.outputs.paths_released }}
steps:
- uses: google-github-actions/release-please-action@v4
- uses: googleapis/release-please-action@v4
id: release
with:
config-file: release-please-config.json
manifest-file: .release-please-manifest.json

publish:
needs: release
if: ${{ needs.release.outputs.releases_created }}
runs-on: ubuntu-latest
strategy:
matrix:
rel: ${{ fromJson(needs.release.outputs.paths_released) }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
registry-url: https://registry.npmjs.org
- name: Install deps
run: |
yarn set version berry
yarn
- name: Build & publish
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
REL_PATH: ${{ matrix.rel.path }}
run: |
case "$REL_PATH" in
packages/enums) yarn enums:build && (cd packages/enums && npm publish --access public) ;;
packages/types) yarn types:build && (cd packages/types && npm publish --access public) ;;
packages/utils) yarn utils:build && (cd packages/utils && npm publish --access public) ;;
packages/event) yarn event:build && (cd packages/event && npm publish --access public) ;;
packages/bucketing) yarn bucketing:build && (cd packages/bucketing && npm publish --access public) ;;
packages/logger) yarn logger:build && (cd packages/logger && npm publish --access public) ;;
packages/rules) yarn rules:build && (cd packages/rules && npm publish --access public) ;;
packages/segments) yarn segments:build && (cd packages/segments && npm publish --access public) ;;
packages/api) yarn api:build && (cd packages/api && npm publish --access public) ;;
packages/data) yarn data:build && (cd packages/data && npm publish --access public) ;;
packages/experience) yarn experience:build && (cd packages/experience && npm publish --access public) ;;
packages/js-sdk) yarn sdk:build && (cd packages/js-sdk && npm publish --access public) ;;
*) echo "Unknown path: $REL_PATH" && exit 1 ;;
esac
24 changes: 12 additions & 12 deletions .release-please-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
{
"packages/js-sdk": "4.3.2",
"packages/enums": "2.2.1",
"packages/types": "3.8.1",
"packages/utils": "2.2.2",
"packages/event": "2.1.2",
"packages/bucketing": "3.1.1",
"packages/logger": "2.1.1",
"packages/rules": "2.1.2",
"packages/segments": "2.1.1",
"packages/api": "2.1.3",
"packages/data": "3.3.2",
"packages/experience": "2.3.1"
"packages/js-sdk": "4.3.3",
"packages/enums": "2.3.0",
"packages/types": "3.9.0",
"packages/utils": "2.2.3",
"packages/event": "2.1.3",
"packages/bucketing": "3.1.2",
"packages/logger": "2.1.2",
"packages/rules": "2.1.3",
"packages/segments": "2.1.2",
"packages/api": "2.1.4",
"packages/data": "3.3.3",
"packages/experience": "2.3.2"
}
8 changes: 8 additions & 0 deletions packages/api/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [2.1.4](https://github.com/convertcom/javascript-sdk/compare/js-sdk-api-v2.1.3...js-sdk-api-v2.1.4) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [2.1.3](https://github.com/convertcom/javascript-sdk/compare/js-sdk-api-v2.1.2...js-sdk-api-v2.1.3) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "2.1.3",
"version": "2.1.4",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-event": ">=2.1.2",
Expand Down
8 changes: 8 additions & 0 deletions packages/bucketing/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [3.1.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-bucketing-v3.1.1...js-sdk-bucketing-v3.1.2) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [3.1.1](https://github.com/convertcom/javascript-sdk/compare/js-sdk-bucketing-v3.1.0...js-sdk-bucketing-v3.1.1) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/bucketing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "3.1.1",
"version": "3.1.2",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
Expand Down
8 changes: 8 additions & 0 deletions packages/data/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [3.3.3](https://github.com/convertcom/javascript-sdk/compare/js-sdk-data-v3.3.2...js-sdk-data-v3.3.3) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [3.3.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-data-v3.3.1...js-sdk-data-v3.3.2) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "3.3.2",
"version": "3.3.3",
"peerDependencies": {
"@convertcom/js-sdk-api": ">=2.1.3",
"@convertcom/js-sdk-bucketing": ">=3.1.1",
Expand Down
13 changes: 13 additions & 0 deletions packages/enums/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,18 @@
# Changelog

## [2.3.0](https://github.com/convertcom/javascript-sdk/compare/js-sdk-enums-v2.2.1...js-sdk-enums-v2.3.0) (2025-09-05)


### Features

* Add support for custom dimensions when tracking conversions ([35dba11](https://github.com/convertcom/javascript-sdk/commit/35dba11880b3bad30bec0e15d2e9853148075ae6))


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [2.2.1](https://github.com/convertcom/javascript-sdk/compare/js-sdk-enums-v2.2.0...js-sdk-enums-v2.2.1) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/enums/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,5 +49,5 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "2.2.1"
"version": "2.3.0"
}
8 changes: 8 additions & 0 deletions packages/event/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [2.1.3](https://github.com/convertcom/javascript-sdk/compare/js-sdk-event-v2.1.2...js-sdk-event-v2.1.3) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [2.1.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-event-v2.1.1...js-sdk-event-v2.1.2) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/event/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "2.1.2",
"version": "2.1.3",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
Expand Down
8 changes: 8 additions & 0 deletions packages/experience/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [2.3.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-experience-v2.3.1...js-sdk-experience-v2.3.2) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [2.3.1](https://github.com/convertcom/javascript-sdk/compare/js-sdk-experience-v2.3.0...js-sdk-experience-v2.3.1) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/experience/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "2.3.1",
"version": "2.3.2",
"peerDependencies": {
"@convertcom/js-sdk-data": ">=3.3.2",
"@convertcom/js-sdk-enums": ">=2.2.1",
Expand Down
11 changes: 11 additions & 0 deletions packages/js-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,16 @@
# Changelog

## [4.3.3](https://github.com/convertcom/javascript-sdk/compare/js-sdk-v4.3.2...js-sdk-v4.3.3) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([5cdfb11](https://github.com/convertcom/javascript-sdk/commit/5cdfb11201c77c349c94a95634e990512841fe55))
* Improve numeric check utility ([8e61900](https://github.com/convertcom/javascript-sdk/commit/8e619009cfa7dc03b2bb1d1836aa7743b9c7de0e))
* Improve numeric check utility ([88e8e08](https://github.com/convertcom/javascript-sdk/commit/88e8e08f7d687c363d10874a5b9ff4b5e3df19e1))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))
Comment thread
abbaseya marked this conversation as resolved.

## [4.3.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-v4.3.1...js-sdk-v4.3.2) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/js-sdk/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,4 +1075,4 @@ Happy converting!

## Credits

Copyright © 2025 Convert Insights, Inc.
Copyright © 2024 Convert Insights, Inc.
2 changes: 1 addition & 1 deletion packages/js-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@
"browserstack-local": "1.5.5"
}
},
"version": "4.3.2",
"version": "4.3.3",
"peerDependencies": {
"@convertcom/js-sdk-api": ">=2.1.3",
"@convertcom/js-sdk-bucketing": ">=3.1.1",
Expand Down
8 changes: 8 additions & 0 deletions packages/logger/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [2.1.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-logger-v2.1.1...js-sdk-logger-v2.1.2) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [2.1.1](https://github.com/convertcom/javascript-sdk/compare/js-sdk-logger-v2.1.0...js-sdk-logger-v2.1.1) (2025-03-26)


Expand Down
2 changes: 1 addition & 1 deletion packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"typescript-eslint": "^8.46.4",
"webpack": "^5.102.1"
},
"version": "2.1.1",
"version": "2.1.2",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1"
}
Expand Down
8 changes: 8 additions & 0 deletions packages/rules/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## [2.1.3](https://github.com/convertcom/javascript-sdk/compare/js-sdk-rules-v2.1.2...js-sdk-rules-v2.1.3) (2025-09-05)


### Bug Fixes

* expose "data" property ([5df9d29](https://github.com/convertcom/javascript-sdk/commit/5df9d295af348485a2f8a1aff8c5440ef1552681))
* Improve numeric check utility ([af0d74c](https://github.com/convertcom/javascript-sdk/commit/af0d74cd027664da90d719a9b9a325dbf60ee62d))

## [2.1.2](https://github.com/convertcom/javascript-sdk/compare/js-sdk-rules-v2.1.1...js-sdk-rules-v2.1.2) (2025-03-26)


Expand Down
Loading