Skip to content

fix/update-deps - #343

Merged
abbaseya merged 2 commits into
main-convertfrom
fix/update-deps
Nov 12, 2025
Merged

fix/update-deps#343
abbaseya merged 2 commits into
main-convertfrom
fix/update-deps

Conversation

@abbaseya

@abbaseya abbaseya commented Nov 12, 2025

Copy link
Copy Markdown
Collaborator

@abbaseya
abbaseya requested a review from a team November 12, 2025 10:27
@abbaseya abbaseya self-assigned this Nov 12, 2025
@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @abbaseya, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a comprehensive update of the project's dependencies. It introduces specific version overrides for several external packages to enhance security and stability, and it also systematically bumps the peer dependency versions for all internal @convertcom/js-sdk modules to their most recent compatible releases, ensuring the entire SDK ecosystem remains up-to-date.

Highlights

  • Dependency Resolutions: A new resolutions field has been added to the root package.json to explicitly pin versions for several third-party dependencies, including form-data, pbkdf2, elliptic, body-parser, rollup, cross-spawn, path-to-regexp, braces, http-proxy-middleware, and nth-check. This is typically done to address security vulnerabilities or ensure compatibility.
  • Internal Peer Dependency Updates: All internal @convertcom/js-sdk-* peer dependencies across various packages (api, bucketing, data, event, experience, js-sdk, logger, rules, segments, types, utils) have been updated to their latest minor or patch versions. This ensures consistency and compatibility within the monorepo.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependencies across multiple packages. It introduces a resolutions block in the root package.json to mitigate security vulnerabilities in transitive dependencies and also bumps versions of internal peer dependencies.

My review has identified several critical issues in the resolutions block:

  • The resolution for path-to-regexp points to a version that is still vulnerable to a ReDoS attack.
  • The resolutions for cross-spawn and http-proxy-middleware point to versions that do not seem to exist in the public npm registry, which will likely cause the build to fail.

Please address these issues to ensure the project is secure and the dependencies can be installed correctly. The other dependency updates in the workspace packages look good.

Comment thread package.json
Comment thread package.json
Comment thread package.json
@abbaseya
abbaseya merged commit 729b109 into main-convert Nov 12, 2025
6 checks passed
@abbaseya
abbaseya deleted the fix/update-deps branch November 12, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants