Skip to content

Main convert #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abbaseya merged 2 commits into from
Nov 12, 2025
Merged

Main convert #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49f6803
chore: force dependency resolutions for critical packages
abbaseya Nov 12, 2025
729b109
Merge pull request #343 from convertcom/fix/update-deps
abbaseya Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6,177 changes: 0 additions & 6,177 deletions demo/remixjs-client-side/pnpm-lock.yaml
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,5 +54,19 @@
"@types/eslint-plugin-mocha": "^10",
"eslint-plugin-mocha": "^11.2.0",
"eslint-plugin-prettier": "^5.5.4"
},
"resolutions": {
"form-data": ">=4.0.4",
"pbkdf2": ">=3.1.3",
"cipher-base": ">=1.0.5",
"sha.js": ">=2.4.12",
"elliptic": ">=6.6.1",
"body-parser": ">=1.20.3",
"rollup": ">=2.79.2",
"cross-spawn": ">=7.0.5",
"path-to-regexp": "^0.1.12",
"braces": ">=3.0.3",
"http-proxy-middleware": ">=2.0.9",
"nth-check": ">=2.0.1"
}
Comment on lines +58 to 71

@gemini-code-assist gemini-code-assist Bot Nov 12, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While using resolutions to mitigate security vulnerabilities is a good practice, it's better to pin dependencies to a specific patched version instead of using a range like >=. This ensures that your builds are deterministic and you don't accidentally pull in a new version with breaking changes or new vulnerabilities. I've updated the versions to specific secure ones. Also, http-proxy-middleware does not have a version 2.0.9; the last version in the 2.x line is 2.0.6, which addresses known vulnerabilities. The resolution for path-to-regexp was pointing to a vulnerable version; I've updated it to a secure one.

Suggested change
"resolutions": {
"form-data": ">=4.0.4",
"pbkdf2": ">=3.1.3",
"cipher-base": ">=1.0.5",
"sha.js": ">=2.4.12",
"elliptic": ">=6.6.1",
"body-parser": ">=1.20.3",
"rollup": ">=2.79.2",
"cross-spawn": ">=7.0.5",
"path-to-regexp": "^0.1.12",
"braces": ">=3.0.3",
"http-proxy-middleware": ">=2.0.9",
"nth-check": ">=2.0.1"
}
"resolutions": {
"form-data": "4.0.0",
"pbkdf2": "3.1.2",
"cipher-base": "1.0.4",
"sha.js": "2.4.11",
"elliptic": "6.5.4",
"body-parser": "1.20.2",
"rollup": "2.79.1",
"cross-spawn": "7.0.3",
"path-to-regexp": "1.8.0",
"braces": "3.0.3",
"http-proxy-middleware": "2.0.6",
"nth-check": "2.0.1"
}

}
12 changes: 6 additions & 6 deletions packages/api/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@
},
"version": "2.1.4",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-event": ">=2.1.2",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-types": ">=3.8.1",
"@convertcom/js-sdk-utils": ">=2.2.2"
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-event": ">=2.1.3",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.9.0",
"@convertcom/js-sdk-utils": ">=2.2.3"
}
}
}
10 changes: 5 additions & 5 deletions packages/bucketing/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@
},
"version": "3.1.2",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-types": ">=3.8.1",
"@convertcom/js-sdk-utils": ">=2.2.2"
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.9.0",
"@convertcom/js-sdk-utils": ">=2.2.3"
}
}
}
18 changes: 9 additions & 9 deletions packages/data/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,13 @@
},
"version": "3.3.3",
"peerDependencies": {
"@convertcom/js-sdk-api": ">=2.1.3",
"@convertcom/js-sdk-bucketing": ">=3.1.1",
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-event": ">=2.1.2",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-rules": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.8.1",
"@convertcom/js-sdk-utils": ">=2.2.2"
"@convertcom/js-sdk-api": ">=2.1.4",
"@convertcom/js-sdk-bucketing": ">=3.1.2",
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-event": ">=2.1.3",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-rules": ">=2.1.3",
"@convertcom/js-sdk-types": ">=3.9.0",
"@convertcom/js-sdk-utils": ">=2.2.3"
}
}
}
8 changes: 4 additions & 4 deletions packages/event/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@
},
"version": "2.1.3",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-types": ">=3.8.1"
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.9.0"
}
}
}
10 changes: 5 additions & 5 deletions packages/experience/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@
},
"version": "2.3.2",
"peerDependencies": {
"@convertcom/js-sdk-data": ">=3.3.2",
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-types": ">=3.8.1"
"@convertcom/js-sdk-data": ">=3.3.3",
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.9.0"
}
}
}
24 changes: 12 additions & 12 deletions packages/js-sdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,16 @@
},
"version": "4.3.3",
"peerDependencies": {
"@convertcom/js-sdk-api": ">=2.1.3",
"@convertcom/js-sdk-bucketing": ">=3.1.1",
"@convertcom/js-sdk-data": ">=3.3.2",
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-event": ">=2.1.2",
"@convertcom/js-sdk-experience": ">=2.3.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-rules": ">=2.1.2",
"@convertcom/js-sdk-segments": ">=2.1.1",
"@convertcom/js-sdk-types": ">=3.8.1",
"@convertcom/js-sdk-utils": ">=2.2.2"
"@convertcom/js-sdk-api": ">=2.1.4",
"@convertcom/js-sdk-bucketing": ">=3.1.2",
"@convertcom/js-sdk-data": ">=3.3.3",
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-event": ">=2.1.3",
"@convertcom/js-sdk-experience": ">=2.3.2",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-rules": ">=2.1.3",
"@convertcom/js-sdk-segments": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.9.0",
"@convertcom/js-sdk-utils": ">=2.2.3"
}
}
}
4 changes: 2 additions & 2 deletions packages/logger/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@
},
"version": "2.1.2",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1"
"@convertcom/js-sdk-enums": ">=2.3.0"
}
}
}
10 changes: 5 additions & 5 deletions packages/rules/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,9 @@
},
"version": "2.1.3",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-types": ">=3.8.1",
"@convertcom/js-sdk-utils": ">=2.2.2"
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.9.0",
"@convertcom/js-sdk-utils": ">=2.2.3"
}
}
}
12 changes: 6 additions & 6 deletions packages/segments/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,10 @@
},
"version": "2.1.2",
"peerDependencies": {
"@convertcom/js-sdk-data": ">=3.3.2",
"@convertcom/js-sdk-enums": ">=2.2.1",
"@convertcom/js-sdk-logger": ">=2.1.1",
"@convertcom/js-sdk-rules": ">=2.1.2",
"@convertcom/js-sdk-types": ">=3.8.1"
"@convertcom/js-sdk-data": ">=3.3.3",
"@convertcom/js-sdk-enums": ">=2.3.0",
"@convertcom/js-sdk-logger": ">=2.1.2",
"@convertcom/js-sdk-rules": ">=2.1.3",
"@convertcom/js-sdk-types": ">=3.9.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/types/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,6 @@
},
"version": "3.9.0",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1"
"@convertcom/js-sdk-enums": ">=2.3.0"
}
}
}
4 changes: 2 additions & 2 deletions packages/utils/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,6 @@
},
"version": "2.2.3",
"peerDependencies": {
"@convertcom/js-sdk-enums": ">=2.2.1"
"@convertcom/js-sdk-enums": ">=2.3.0"
}
}
}
Loading