feat/full-chain-integration-tests - #371
Merged
Merged
Conversation
abbaseya
force-pushed
the
feat/full-chain-integration-tests
branch
from
April 5, 2026 14:01
5a2a9f5 to
ca40960
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request migrates the browser and integration testing framework from Karma to Playwright, introducing new test suites and a comprehensive testing guide. It also includes package version increments and a bug fix for rule evaluation logic. Feedback focuses on improving the new test code by removing unused helper functions and dead code, enhancing error handling during configuration loading, and refactoring manual polling into a cleaner Promise-based approach.
abbaseya
force-pushed
the
feat/full-chain-integration-tests
branch
5 times, most recently
from
April 5, 2026 14:28
bc5cece to
a248610
Compare
- Replace Karma + BrowserStack browser tests with Playwright - Port all UMD bundle browser tests (19 tests) - Add full-chain integration tests matching PHP SDK pattern (17 tests per mode) - Support 3 auth modes: static, live (public key), live-secret (key+secret) - Upgrade CI to Node 22, corepack, actions v4 - Remove Karma, BrowserStack, and Puppeteer dependencies - Add TESTING.md documentation
abbaseya
force-pushed
the
feat/full-chain-integration-tests
branch
from
April 5, 2026 14:31
a248610 to
be7e235
Compare
|
JosephSamirL
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.