Main convert - #372
Merged
Merged
Conversation
fix/merge-main
Add @convertcom/js-sdk-cloudflare with edge-specific helpers for running Convert experiments inside Cloudflare Workers: KV-backed DataStore adapter, edge config cache, cookie helpers, and variation-aware cache utilities. Includes a demo Worker (demo/cloudflare-workers/) demonstrating page-level A/B testing with HTMLRewriter, asset swaps, split URL redirects, and SPA injection patterns. Updates release-please config, publish workflows, and root build scripts to support the new package.
Fix SDK singleton race condition by caching the initialization promise so concurrent cold-start requests share one init. Guard JSON.parse calls in KVDataStore and EdgeConfigCache against corrupted KV data. Type the applyVariation parameter as BucketedVariation instead of any.
…tional persistence
Address code review on Cloudflare Workers integration:
- Replace KV-based EdgeConfigCache with Cloudflare built-in fetch cache
(cf: { cacheTtl, cacheEverything }) — simpler, free on all plans, no KV
dependency needed for basic setup
- Mark KVDataStore as optional — deterministic MurmurHash bucketing means
the same visitor ID always gets the same variation without persistence
- Document that releaseQueues() must be called in waitUntil() before the
Worker finishes, since the SDK setTimeout-based event timer will not fire
in stateless Workers
- Update demo, README, and wrangler.toml to reflect KV-free default setup
- Replace Karma + BrowserStack browser tests with Playwright - Port all UMD bundle browser tests (19 tests) - Add full-chain integration tests matching PHP SDK pattern (17 tests per mode) - Support 3 auth modes: static, live (public key), live-secret (key+secret) - Upgrade CI to Node 22, corepack, actions v4 - Remove Karma, BrowserStack, and Puppeteer dependencies - Add TESTING.md documentation
…ests feat/full-chain-integration-tests
Regenerate yarn.lock after merging latest main-convert changes.
Remove KV namespace as a required setup step since the implementation now uses Cloudflare's native cf.cacheTtl for config caching and deterministic MurmurHash bucketing for visitor assignment.
- Add built-in origin server (origin/) with HTML pages for all routes
- Map URL paths to location properties matching the staging project
(/events → "events", /statistics → "statistics", /pricing → "pricing")
- Pass visitor properties for audience matching ({mobile: true})
- Use fetchOrigin() helper to avoid infinite loop on fetch(request)
- Accept */* in addition to text/html for curl compatibility
- Add ORIGIN_URL env var to wrangler.toml for configurable origin
- Pre-configure staging SDK key (10035569/10034190)
- Merge verification steps and troubleshooting into README
- Replace 4 static HTML files with a shared template in server.js - Merge ROUTE_LOCATION_MAP and feature key constants into a single ROUTES config object - Deduplicate statistics/pricing experiment logic in decideForRoute() by branching on experienceKey vs runExperiences Addresses SonarCloud duplicated lines threshold (target ≤ 3%).
feat/cloudflare-workers
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the @convertcom/js-sdk-cloudflare package and a Cloudflare Workers demo for edge experimentation. It also migrates the js-sdk testing framework from Karma to Playwright, adding comprehensive integration tests. Feedback identifies a TypeScript destructuring error in the demo worker, recommends restoring the build step in the browser test script to ensure accuracy, and suggests replacing any types with specific SDK types for better type safety.
JosephSamirL
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.