Update package versions - #378
Merged
Merged
Conversation
Bumps @convertcom/js-sdk-types peer range to >=3.11.0 across api, bucketing, data, event, experience, js-sdk, rules, segments; bumps @convertcom/js-sdk-rules to >=2.1.4 in data, js-sdk, segments. Picked up by yarn 4 during a local build. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the peer dependency ranges for @convertcom/js-sdk-types and @convertcom/js-sdk-rules across multiple packages in the monorepo. The reviewer recommended incrementing the versions of the modified packages to ensure proper publication and consumer notification. Additionally, the reviewer identified the unintentional removal of trailing newlines in several package.json files and provided suggestions to restore them for consistency with project formatting standards.
Reorders the QA workflow to install yarn deps before Playwright browsers, and uses `yarn playwright install` instead of `npx`. With `npx` running before `yarn`, node_modules was empty so npx fetched the latest playwright from npm (1.60.0 today) and downloaded chromium binaries for that revision. The job then ran tests against the project's pinned @playwright/test@1.59.1, which expects a different chromium-headless-shell build, hitting "Executable doesn't exist at .../chromium_headless_shell-1217/..." on every browser test. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
JosephSamirL
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.