Main convert - #388
Merged
Merged
Conversation
Update Serving API - from backend PR #6633
Set the User-Agent header to ConvertAgent/1.0 on every outbound HTTP request from HttpClient when running server-side. Browser path stays untouched (browsers strip User-Agent per the W3C forbidden-header list, and the browser's natural UA does not trigger isbot anyway). Two branches updated: - fetch path (server-with-fetch + browser): conditional on runtimeResult.runtime !== 'browser' - old-nodejs path: unconditional (always server-side) Why this matters: ApiManager's _trackingSource (network.source on the wire) is customer-configurable and could be overridden via SDK config, or via a CI VERSION-stamping pattern. Either could silently break the metrics-endpoint's source-field bypass. The UA is now an SDK invariant: applied at the lowest HTTP transport layer, after any caller-provided headers, so neither config nor higher-layer headers can override it. Matches the metrics-endpoint's isConvertAgentUA bypass that has been in place since 2026-05-20. Source-field bypass at the metrics endpoint stays in place as legacy fallback for already-deployed SDK versions. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Replaces the two hard-coded 'ConvertAgent/1.0' literals in the http-client with a single named const declared near the imports, so the value is named once and the two injection sites reference it. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…r-agent feat(utils): always announce as Convert SDK via ConvertAgent User-Agent
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors type definitions by removing redundant billing types and transitioning goal and trigger types from string literals to enums. It also updates the HttpClient to include a specific User-Agent header for server-side requests to identify SDK traffic. Feedback focuses on type incompatibilities introduced in the ConfigGoal union where specific subtypes use literals not present in the new enum, outdated documentation comments, and potential side effects in the HttpClient caused by mutating the caller's header object instead of cloning it.
JosephSamirL
approved these changes
May 25, 2026
Hotfix/sync main
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.